Skip to content

Conversation

@avivkeller
Copy link
Member

Closes #558

Copilot AI review requested due to automatic review settings January 7, 2026 02:00
@avivkeller avivkeller requested a review from a team as a code owner January 7, 2026 02:00
@vercel
Copy link

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
api-docs-tooling Ready Ready Preview Jan 7, 2026 2:00am

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.97%. Comparing base (23ffbb1) to head (37e6dda).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/generators/jsx-ast/utils/buildContent.mjs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   79.97%   79.97%           
=======================================
  Files         127      127           
  Lines       12283    12276    -7     
  Branches      866      866           
=======================================
- Hits         9823     9818    -5     
+ Misses       2457     2455    -2     
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

web Generator

File Base Head Diff
n-api.html 896.10 KB 807.45 KB -88.65 KB (-9.89%)
util.html 683.06 KB 638.20 KB -44.86 KB (-6.57%)
buffer.html 868.65 KB 827.74 KB -40.91 KB (-4.71%)
stream.html 847.86 KB 808.52 KB -39.34 KB (-4.64%)
process.html 667.55 KB 629.00 KB -38.55 KB (-5.77%)
fs.html 1.28 MB 1.25 MB -36.57 KB (-2.79%)
webcrypto.js 410.68 KB 447.18 KB +36.49 KB (+8.89%)
test.html 684.55 KB 654.68 KB -29.87 KB (-4.36%)
http2.html 747.27 KB 718.58 KB -28.68 KB (-3.84%)
http.html 707.84 KB 681.13 KB -26.71 KB (-3.77%)
webcrypto.html 479.95 KB 502.91 KB +22.96 KB (+4.78%)
url.html 344.26 KB 321.88 KB -22.37 KB (-6.50%)
crypto.html 976.76 KB 956.03 KB -20.73 KB (-2.12%)
cli.html 486.90 KB 466.50 KB -20.40 KB (-4.19%)
events.html 443.59 KB 425.95 KB -17.64 KB (-3.98%)
deprecations.html 487.59 KB 471.53 KB -16.06 KB (-3.29%)
addons.html 278.36 KB 263.09 KB -15.27 KB (-5.49%)
module.html 320.38 KB 305.51 KB -14.88 KB (-4.64%)
packages.html 165.19 KB 151.50 KB -13.69 KB (-8.29%)
assert.html 330.76 KB 317.86 KB -12.90 KB (-3.90%)
child_process.html 369.41 KB 356.51 KB -12.90 KB (-3.49%)
worker_threads.html 354.87 KB 342.36 KB -12.51 KB (-3.52%)
tls.html 349.96 KB 337.85 KB -12.11 KB (-3.46%)
readline.html 245.35 KB 233.63 KB -11.72 KB (-4.78%)
repl.html 186.43 KB 174.71 KB -11.72 KB (-6.29%)
vm.html 333.52 KB 321.80 KB -11.72 KB (-3.51%)
modules.html 184.27 KB 172.94 KB -11.32 KB (-6.15%)
path.html 140.81 KB 130.28 KB -10.54 KB (-7.48%)
single-executable-applications.html 107.84 KB 97.70 KB -10.14 KB (-9.40%)
esm.html 158.96 KB 149.61 KB -9.35 KB (-5.88%)
v8.html 284.10 KB 275.15 KB -8.96 KB (-3.15%)
async_hooks.html 156.31 KB 147.75 KB -8.56 KB (-5.48%)
dns.html 281.93 KB 273.37 KB -8.56 KB (-3.04%)
diagnostics_channel.html 221.52 KB 213.35 KB -8.17 KB (-3.69%)
cluster.html 192.33 KB 184.95 KB -7.38 KB (-3.84%)
errors.html 408.90 KB 401.52 KB -7.38 KB (-1.80%)
net.html 337.63 KB 330.25 KB -7.38 KB (-2.19%)
webstreams.html 329.31 KB 321.93 KB -7.38 KB (-2.24%)
crypto.js 1.20 MB 1.21 MB +6.32 KB (+0.51%)
inspector.html 151.39 KB 145.20 KB -6.20 KB (-4.09%)
perf_hooks.html 354.84 KB 348.65 KB -6.20 KB (-1.75%)
async_context.html 159.82 KB 154.02 KB -5.80 KB (-3.63%)
console.html 141.54 KB 135.74 KB -5.80 KB (-4.10%)
globals.html 221.05 KB 215.25 KB -5.80 KB (-2.62%)
https.html 146.31 KB 140.90 KB -5.41 KB (-3.70%)
report.html 180.42 KB 175.01 KB -5.41 KB (-3.00%)
zlib.html 271.98 KB 266.57 KB -5.41 KB (-1.99%)
dgram.html 181.74 KB 177.52 KB -4.22 KB (-2.32%)
sqlite.html 230.32 KB 226.10 KB -4.22 KB (-1.83%)
permissions.html 59.60 KB 55.78 KB -3.83 KB (-6.42%)
tracing.html 85.34 KB 81.91 KB -3.43 KB (-4.02%)
domain.html 102.86 KB 99.82 KB -3.04 KB (-2.95%)
intl.html 61.41 KB 58.37 KB -3.04 KB (-4.95%)
typescript.html 55.66 KB 52.62 KB -3.04 KB (-5.46%)
environment_variables.html 45.47 KB 42.82 KB -2.64 KB (-5.82%)
punycode.html 62.70 KB 60.05 KB -2.64 KB (-4.22%)
timers.html 122.28 KB 119.64 KB -2.64 KB (-2.16%)
synopsis.html 44.22 KB 41.97 KB -2.25 KB (-5.09%)
debugger.html 54.26 KB 52.40 KB -1.86 KB (-3.42%)
querystring.html 61.79 KB 59.94 KB -1.86 KB (-3.00%)
quic.html 334.04 KB 332.18 KB -1.86 KB (-0.56%)
wasi.html 67.99 KB 66.14 KB -1.86 KB (-2.73%)
styles.css 121.66 KB 119.88 KB -1.79 KB (-1.47%)
tty.html 86.74 KB 85.28 KB -1.46 KB (-1.68%)
os.html 132.65 KB 131.58 KB -1.07 KB (-0.80%)
string_decoder.html 53.65 KB 52.58 KB -1.07 KB (-1.99%)
embedding.html 58.39 KB 57.72 KB -688.00 B (-1.15%)
documentation.html 36.07 KB 36.18 KB +120.00 B (+0.32%)
index.html 34.59 KB 34.71 KB +120.00 B (+0.34%)
assert.js 463.17 KB 463.15 KB -24.00 B (-0.01%)
async_context.js 189.45 KB 189.42 KB -24.00 B (-0.01%)
async_hooks.js 188.94 KB 188.92 KB -24.00 B (-0.01%)
buffer.js 1.11 MB 1.11 MB -24.00 B (-0.00%)
child_process.js 483.18 KB 483.15 KB -24.00 B (-0.00%)
cluster.js 201.69 KB 201.67 KB -24.00 B (-0.01%)
console.js 110.21 KB 110.18 KB -24.00 B (-0.02%)
dgram.js 178.09 KB 178.07 KB -24.00 B (-0.01%)
diagnostics_channel.js 251.63 KB 251.60 KB -24.00 B (-0.01%)
dns.js 281.95 KB 281.92 KB -24.00 B (-0.01%)
domain.js 90.57 KB 90.54 KB -24.00 B (-0.03%)
embedding.js 36.45 KB 36.43 KB -24.00 B (-0.06%)
events.js 566.70 KB 566.68 KB -24.00 B (-0.00%)
fs.js 1.30 MB 1.30 MB -24.00 B (-0.00%)
http.js 711.58 KB 711.56 KB -24.00 B (-0.00%)
http2.js 849.48 KB 849.46 KB -24.00 B (-0.00%)
https.js 162.69 KB 162.67 KB -24.00 B (-0.01%)
inspector.js 111.12 KB 111.09 KB -24.00 B (-0.02%)
intl.js 35.38 KB 35.36 KB -24.00 B (-0.07%)
n-api.js 700.75 KB 700.73 KB -24.00 B (-0.00%)
net.js 298.65 KB 298.62 KB -24.00 B (-0.01%)
os.js 111.70 KB 111.67 KB -24.00 B (-0.02%)
packages.js 122.43 KB 122.41 KB -24.00 B (-0.02%)
path.js 103.00 KB 102.98 KB -24.00 B (-0.02%)
perf_hooks.js 382.70 KB 382.67 KB -24.00 B (-0.01%)
process.js 724.42 KB 724.39 KB -24.00 B (-0.00%)
punycode.js 28.65 KB 28.63 KB -24.00 B (-0.08%)
querystring.js 31.70 KB 31.67 KB -24.00 B (-0.07%)
quic.js 193.15 KB 193.12 KB -24.00 B (-0.01%)
readline.js 232.81 KB 232.79 KB -24.00 B (-0.01%)
repl.js 212.00 KB 211.97 KB -24.00 B (-0.01%)
single-executable-applications.js 74.22 KB 74.20 KB -24.00 B (-0.03%)
sqlite.js 227.42 KB 227.40 KB -24.00 B (-0.01%)
stream.js 901.17 KB 901.14 KB -24.00 B (-0.00%)
string_decoder.js 31.47 KB 31.45 KB -24.00 B (-0.07%)
synopsis.js 15.31 KB 15.28 KB -24.00 B (-0.15%)
test.js 849.11 KB 849.09 KB -24.00 B (-0.00%)
timers.js 102.91 KB 102.89 KB -24.00 B (-0.02%)
tls.js 333.36 KB 333.34 KB -24.00 B (-0.01%)
tracing.js 77.72 KB 77.70 KB -24.00 B (-0.03%)
tty.js 50.42 KB 50.40 KB -24.00 B (-0.05%)
url.js 343.59 KB 343.57 KB -24.00 B (-0.01%)
util.js 777.94 KB 777.92 KB -24.00 B (-0.00%)
v8.js 278.43 KB 278.41 KB -24.00 B (-0.01%)
vm.js 370.70 KB 370.67 KB -24.00 B (-0.01%)
wasi.js 43.25 KB 43.23 KB -24.00 B (-0.05%)
worker_threads.js 409.46 KB 409.43 KB -24.00 B (-0.01%)
zlib.js 321.43 KB 321.41 KB -24.00 B (-0.01%)
environment_variables.js 15.71 KB 15.69 KB -19.00 B (-0.12%)
errors.js 321.45 KB 321.43 KB -19.00 B (-0.01%)
globals.js 123.50 KB 123.48 KB -19.00 B (-0.02%)
index.js 9.42 KB 9.40 KB -19.00 B (-0.20%)
modules.js 152.90 KB 152.88 KB -19.00 B (-0.01%)
permissions.js 27.91 KB 27.89 KB -19.00 B (-0.07%)
webstreams.js 303.74 KB 303.72 KB -19.00 B (-0.01%)
cli.js 283.19 KB 283.18 KB -14.00 B (-0.00%)
documentation.js 8.61 KB 8.60 KB -14.00 B (-0.16%)
esm.js 133.82 KB 133.81 KB -14.00 B (-0.01%)
module.js 347.08 KB 347.07 KB -14.00 B (-0.00%)
addons.js 297.87 KB 297.86 KB -9.00 B (-0.00%)
debugger.js 29.58 KB 29.57 KB -9.00 B (-0.03%)
deprecations.js 256.88 KB 256.87 KB -9.00 B (-0.00%)
report.js 187.76 KB 187.75 KB -9.00 B (-0.00%)
typescript.js 23.97 KB 23.97 KB -9.00 B (-0.04%)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the @node-core/ui-components package from version 1.4.2 to 1.5.2, which involves migrating from a custom notification implementation to built-in copy functionality in the BaseCodeBox component.

Key changes:

  • Simplified CodeBox component by removing custom notification handling for copy operations
  • Removed NotificationProvider wrapper from document layout structure
  • Updated dependency versions including Tailwind CSS from 4.1.17 to 4.1.18

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/generators/web/ui/components/CodeBox.jsx Simplified component by removing custom onCopy handler and notification dependencies, now uses BaseCodeBox's built-in copy functionality
src/generators/web/constants.mjs Removed NotificationProvider import definition as it's no longer needed
src/generators/jsx-ast/utils/buildContent.mjs Removed NotificationProvider wrapper from document layout, flattened component hierarchy
package.json Bumped @node-core/ui-components from 1.4.2 to 1.5.2
npm-shrinkwrap.json Updated lockfile with new dependency versions, removed @radix-ui/react-toast dependency
Files not reviewed (1)
  • npm-shrinkwrap.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and fast-tracking!

@ovflowd ovflowd merged commit 2cff615 into main Jan 7, 2026
26 checks passed
@ovflowd ovflowd deleted the bump-ui branch January 7, 2026 16:43
@ovflowd ovflowd added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast track This PR can land before the typical review time, with a :+1: from collaborators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants