-
Notifications
You must be signed in to change notification settings - Fork 24
feat(metabar): subtle indicators #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
==========================================
- Coverage 79.97% 79.95% -0.02%
==========================================
Files 127 127
Lines 12283 12285 +2
Branches 866 866
==========================================
Hits 9823 9823
- Misses 2457 2459 +2
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| File | Base | Head | Diff |
|---|---|---|---|
cli.html |
486.90 KB | 486.13 KB | -786.00 B (-0.16%) |
process.html |
667.55 KB | 667.15 KB | -410.00 B (-0.06%) |
styles.css |
121.66 KB | 121.28 KB | -394.00 B (-0.32%) |
http.html |
707.84 KB | 707.58 KB | -274.00 B (-0.04%) |
globals.html |
221.05 KB | 220.80 KB | -258.00 B (-0.11%) |
errors.html |
408.90 KB | 408.65 KB | -256.00 B (-0.06%) |
buffer.html |
868.65 KB | 868.44 KB | -221.00 B (-0.02%) |
zlib.html |
271.98 KB | 271.77 KB | -210.00 B (-0.08%) |
webcrypto.html |
479.95 KB | 479.79 KB | -168.00 B (-0.03%) |
crypto.html |
976.76 KB | 976.61 KB | -153.00 B (-0.02%) |
module.html |
320.38 KB | 320.24 KB | -147.00 B (-0.04%) |
util.html |
683.06 KB | 682.93 KB | -141.00 B (-0.02%) |
vm.html |
333.52 KB | 333.40 KB | -128.00 B (-0.04%) |
assert.html |
330.76 KB | 330.64 KB | -120.00 B (-0.04%) |
fs.html |
1.28 MB | 1.28 MB | -113.00 B (-0.01%) |
esm.html |
158.96 KB | 158.86 KB | -105.00 B (-0.06%) |
test.html |
684.55 KB | 684.44 KB | -105.00 B (-0.01%) |
url.html |
344.26 KB | 344.18 KB | -74.00 B (-0.02%) |
timers.html |
122.28 KB | 122.21 KB | -72.00 B (-0.06%) |
net.html |
337.63 KB | 337.56 KB | -65.00 B (-0.02%) |
async_context.html |
159.82 KB | 159.76 KB | -63.00 B (-0.04%) |
inspector.html |
151.39 KB | 151.33 KB | -63.00 B (-0.04%) |
n-api.html |
896.10 KB | 896.04 KB | -63.00 B (-0.01%) |
modules.html |
184.27 KB | 184.21 KB | -53.00 B (-0.03%) |
cluster.html |
192.33 KB | 192.28 KB | -46.00 B (-0.02%) |
perf_hooks.html |
354.84 KB | 354.80 KB | -46.00 B (-0.01%) |
worker_threads.html |
354.87 KB | 354.83 KB | -42.00 B (-0.01%) |
repl.html |
186.43 KB | 186.41 KB | -23.00 B (-0.01%) |
diagnostics_channel.html |
221.52 KB | 221.50 KB | -21.00 B (-0.01%) |
packages.html |
165.19 KB | 165.17 KB | -21.00 B (-0.01%) |
stream.html |
847.86 KB | 847.84 KB | -21.00 B (-0.00%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR replaces explicit badge components with subtle CSS-based visual indicators for stability levels in the MetaBar component. The changes remove the Badge component import and use text decorations (strikethrough for deprecated/legacy, underline for experimental) with color coding to indicate stability status.
Key changes:
- Removed Badge component usage and replaced with CSS text-decoration styling
- Changed stability mapping from badge kinds/labels to CSS class names
- Applied color-coded decorations: danger (red) for deprecated, info (blue) for legacy, warning (yellow) for experimental
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/generators/web/ui/components/MetaBar/index.module.css | Adds CSS rules for deprecated, legacy, and experimental styling using text-decoration and colors; however, the selectors are malformed |
| src/generators/web/ui/components/MetaBar/index.jsx | Replaces Badge component with span elements using CSS classes from STABILITY_CLASS_MAP; updates JSDoc type from string to number |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| styles.legacy, | ||
| ]; | ||
|
|
||
| const STABILITY_TITLE_MAP = ['Deprecated', 'Experimental', undefined, 'Legacy']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need an explicit hard-coded map? I'm not sure how I feel about this.
|
@avivkeller could you add screenshot of before/after and the reasoning behind this change? I'm kinda -1 with this change. |
Noted. I was trying a different design, but I've gotten some -1 feedback, so I think the current layout is good. |



Replaces the Badges on the MetaBar with more subtle indicators:
These colors match those of the badges.