ci: always run "./update.sh" even if musl is missing - #2581
Conversation
- swap calls to `fuction.sh` for normal Node.js file operations - Assume the Alpine build might lag - Read the `security` flag from nodejs.org instead of unofficial-builds
| ); | ||
|
|
||
| const supportedVersions = versionsOutput.trim().split(' '); | ||
| let files = readdirSync('./'); |
There was a problem hiding this comment.
Think this probably needs to use something like import.meta.dirname
There was a problem hiding this comment.
Also used the Sync versions of the methods that probably should be swapped
|
Marking as Ready, now that the Security releases are all out |
|
I let Copilot have a look, with the conclusion that it solves the issue you describe. 👍 It did however identify an edge case of updates that combine majors with a mixture of security / non-security. If the intention is to allow the security releases to continue without musl, and block only the non-security releases, instead of exiting completely, then the suggested change was: from I would be happy if the mainstream expected case of a bundle of security updates like 22.x, 24.x & 26.x are handled. If you want to look at the edge case, please go ahead. I'll approve anyway, so you have free hand. Also, if this is a good opportunity to add some additional logging, then please think about this. It hasn't been clear so far if a release has been identified as security or not in the logs, which are anyway quite sparse. |
|
Flipped it back to draft, because as I started to add logging, I ended up redoing so much of it. Will see if it makes sense in the end, and maybe to a new PR |
Description
Security releases are still getting stuck on Unofficial builds, so ensure that the
securityflag is read from the nodejs.orgindex.json, not the unofficial-builds version, that is missing till the build is queued.Motivation and Context
fuction.shfor normal Node.js file operationssecurityflag from nodejs.org instead of unofficial-buildsTesting Details
Example Output(if appropriate)
Types of changes
Checklist