chore: add ESLint setup - #2585
Conversation
|
BTW: Whilst I was looking for a replacement for I don't want to suggest this alternative for a PR or merge, since I think the current setup is good enough as it is. It is just a Proof of Concept development to share with you. I'm OK with adding your PR which just does a base ESLint JS linting without additional plugins like stylistic. Prettier and @stylistic/eslint-plugin disagree about formatting, so it's not practical to use both on the same files. |
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Co-authored-by: Nick Schonning <nschonni@gmail.com>
| "format:javascript": "eslint --fix", | ||
| "format:javascript:check": "eslint", |
There was a problem hiding this comment.
It would be more consistent to call these
lint:eslint
lint:eslint:fix
https://prettier.io/docs/comparison makes the distinction between formatters and linters
I am not hung up on the naming though. Anything that works, and is documented correctly is fine with me.
There was a problem hiding this comment.
I can change the name. The reason I tend to avoid tool names in the targets, is that you can/do change them overtime, so keeping them about the purpose reduces noise in the repos. EX: .github/eslint.yml needs to be renamed if you change tools, but if you change the tool inside a call target in the package.json, nothing else changes. The git file history also remains
There was a problem hiding this comment.
In the case of ESLint, it could be extended to cover other types of files, like json, so then javascript wouldn't be right either.
Perhaps at some later stage the GitHub action workflows could be consolidated so they're not named after the individual tools, but instead after the purpose. I would however give this much lower priority than solving the automation issue to produce the releases, and preparing for the other changes (Alpine Tier 2 & alpha releases).
Let's leave it the way it is right now.
Description
Generated the config and ignored the one use that was still flagged inline.
Motivation and Context
Testing Details
Example Output(if appropriate)
Types of changes
Checklist