Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions workflow and delete old CI configurations #959

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add GitHub Actions workflow and delete old CI configurations #959

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73f436e
Add GitHub Actions workflow
tniessen Oct 21, 2023
02b5c5f
fixup!
tniessen Oct 21, 2023
b487e54
fixup!
tniessen Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: CI

on:
pull_request:
push:

permissions:
contents: read

jobs:
test:
runs-on: ${{matrix.os}}
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version: ['0.10', 0.12, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node-version: ['0.10', 0.12, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21]
node-version: ['0.10', 0.12, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23]

fail-fast: false
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Set up Node.js ${{matrix.node-version}}
uses: actions/setup-node@v3
Comment on lines +20 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/checkout@v3
- name: Set up Node.js ${{matrix.node-version}}
uses: actions/setup-node@v3
uses: actions/checkout@v4
- name: Set up Node.js ${{matrix.node-version}}
uses: actions/setup-node@v4

with:
node-version: ${{matrix.node-version}}
- name: Install dependencies
run: npm install
- name: Build
run: node_modules/.bin/node-gyp rebuild --directory test
- name: Test
run: node_modules/.bin/tap --gc test/js/*-test.js