Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: runtime deprecate crypto.fips #55019

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

crypto: runtime deprecate crypto.fips #55019

wants to merge 1 commit into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 19, 2024

Let's runtime deprecate crypto.fips attribute.

cc @nodejs/crypto

@anonrig anonrig added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 19, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Sep 19, 2024
@anonrig anonrig force-pushed the runtime-deprecate-crypto-fips branch 2 times, most recently from eb18fd4 to d16ddda Compare September 19, 2024 19:56
@anonrig anonrig force-pushed the runtime-deprecate-crypto-fips branch from d16ddda to e5bb84d Compare September 19, 2024 20:03
@RedYetiDev RedYetiDev added the deprecations Issues and PRs related to deprecations. label Sep 19, 2024
RedYetiDev
RedYetiDev reviewed Sep 19, 2024
View reviewed changes
lib/crypto.js Show resolved Hide resolved
lib/crypto.js Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (291d90a) to head (e5bb84d).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55019   +/-   ##
=======================================
  Coverage   88.04%   88.04%           
=======================================
  Files         652      652           
  Lines      183764   183765    +1     
  Branches    35862    35864    +2     
=======================================
+ Hits       161787   161805   +18     
+ Misses      15233    15225    -8     
+ Partials     6744     6735    -9
Files with missing lines Coverage Δ
lib/crypto.js 93.35% <100.00%> (+0.01%) ⬆️

... and 25 files with indirect coverage changes

@RedYetiDev RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62580/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedYetiDev RedYetiDev RedYetiDev left review comments

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anonrig @nodejs-github-bot @benjamingr @RedYetiDev