Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: assert write return values in buffer-bigint64 #57212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Feb 26, 2025

https://nodejs.org/api/buffer.html#bufwritebigint64bevalue-offset

Returns: offset plus the number of bytes written.

add more cases that assert this

discovered by oven-sh/bun#17694

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (e03af77) to head (5bc1af9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57212      +/-   ##
==========================================
- Coverage   90.27%   90.25%   -0.02%     
==========================================
  Files         630      630              
  Lines      184634   184634              
  Branches    36129    36125       -4     
==========================================
- Hits       166674   166638      -36     
- Misses      11009    11031      +22     
- Partials     6951     6965      +14     

see 36 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants