-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: port initializeImportMeta
to native
#57286
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57286 +/- ##
==========================================
- Coverage 90.24% 90.21% -0.04%
==========================================
Files 630 630
Lines 184908 185263 +355
Branches 36181 36253 +72
==========================================
+ Hits 166874 167134 +260
+ Misses 11061 11057 -4
- Partials 6973 7072 +99
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not great with cpp, but it looks fine AFAICT, and conceptually checks out 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the original implementation is much easier to understand and maintain.
Do you have any suggestions on how to improve it? |
Co-authored-by: Jacob Smith <[email protected]> Co-authored-by: Edy Silva <[email protected]>
Supersedes #57003.
We should probably avoid translating the URL to a path twice when the user needs both
dirname
andfilename
, but I'm not sure if there's an elegant way to do it without crossing the C++/JS bundary.