-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: clarify --cpu-prof-name allowed values #57433
Closed
Closed
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be healthy to add an example?
mertcanaltin
approved these changes
Mar 13, 2025
Sure! It could be helpful, thanks. Not committing the examples right now since after trying out the parameter there could be some cases in which the templates actually work. I'm waiting for a reply here #57418 (comment) |
jasnell
approved these changes
Mar 14, 2025
mertcanaltin
approved these changes
Mar 16, 2025
anonrig
approved these changes
Mar 16, 2025
anonrig
approved these changes
Mar 16, 2025
jasnell
reviewed
Mar 16, 2025
jasnell
pushed a commit
that referenced
this pull request
Mar 16, 2025
Refs: #57418 PR-URL: #57433 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Landed in 8ccbfb6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clarification for the
--cpu-prof-name
cli parameter allowed values.Refs: #57418