Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify --cpu-prof-name allowed values #57433

Closed
wants to merge 3 commits into from

Conversation

cecia234
Copy link
Contributor

Added clarification for the --cpu-prof-name cli parameter allowed values.

Refs: #57418

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Mar 13, 2025
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be healthy to add an example?

@cecia234
Copy link
Contributor Author

Sure! It could be helpful, thanks. Not committing the examples right now since after trying out the parameter there could be some cases in which the templates actually work. I'm waiting for a reply here #57418 (comment)

jasnell pushed a commit that referenced this pull request Mar 16, 2025
Refs: #57418
PR-URL: #57433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 16, 2025

Landed in 8ccbfb6

@jasnell jasnell closed this Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants