-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: ensure expected JWK alg in SubtleCrypto.importKey RSA imports #57450
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
panva:fix-webcrypto-jwk-import-alg-checks
Mar 16, 2025
Merged
crypto: ensure expected JWK alg in SubtleCrypto.importKey RSA imports #57450
nodejs-github-bot
merged 1 commit into
nodejs:main
from
panva:fix-webcrypto-jwk-import-alg-checks
Mar 16, 2025
+74
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
jasnell
approved these changes
Mar 13, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57450 +/- ##
=======================================
Coverage 90.20% 90.21%
=======================================
Files 629 629
Lines 184948 184947 -1
Branches 36204 36214 +10
=======================================
+ Hits 166837 166853 +16
+ Misses 11057 11048 -9
+ Partials 7054 7046 -8
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cc @nodejs/web-standards |
anonrig
approved these changes
Mar 16, 2025
Landed in 0cfc471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
confirmed-bug
Issues with confirmed bugs.
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
web-standards
Issues and PRs related to Web APIs
webcrypto
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on SHA-3 addition to webcrypto and updating the test suite I noticed that RSA import JWK "alg" values were forced to e.g. PS256 (depending on the digest) even for RSA-OAEP and RSASSA-PKCS1-v1_5 algorithms which should be rejected.
While debugging this I noticed that
normalizeHashName
context that;In this PR I made the following changes:
I've updated tests to
You can verify the prior bugged behaviour with the following script
Details