Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix the incorrect splitting of multiple words #57454

Closed
wants to merge 1 commit into from

Conversation

letianpailove
Copy link
Contributor

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 14, 2025
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 14, 2025
@lpinca
Copy link
Member

lpinca commented Mar 14, 2025

The commit message should start with an imperative verb. Can you please change "fixed" to "fix" and force push? Thank you.

@letianpailove
Copy link
Contributor Author

@aduh95 How can I get this pr to merge into the main branch? The notice tell me: Merging is blocked. You're not authorized to push to this branch.

@letianpailove letianpailove changed the title doc: fixed the incorrect splitting of multiple words doc: fix the incorrect splitting of multiple words Mar 16, 2025
jasnell pushed a commit that referenced this pull request Mar 16, 2025
PR-URL: #57454
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 16, 2025

Landed in 8b41272

@jasnell jasnell closed this Mar 16, 2025
@jasnell
Copy link
Member

jasnell commented Mar 16, 2025

@letianpailove ... PRs can only be merged by approved project collaborators and we typically do not use the "Merge" button. I've landed the PR. Thank you for the contribution! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants