Skip to content

util: inspect: do not crash on an Error stack pointing to itself #58196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025
Merged

util: inspect: do not crash on an Error stack pointing to itself #58196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b819f9
util: inspect: do not crash on an Error stack pointing to itself
SamVerschueren May 6, 2025
f616bcc
fix: linting error
SamVerschueren May 6, 2025
111b9ca
chore: address feedback
SamVerschueren Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/internal/util/inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1319,7 +1319,12 @@ function getStackString(ctx, error) {
if (typeof error.stack === 'string') {
return error.stack;
}
return formatValue(ctx, error.stack);
ctx.seen.push(error);
ctx.indentationLvl += 4;
const result = formatValue(ctx, error.stack);
ctx.indentationLvl -= 4;
ctx.seen.pop();
return `${ErrorPrototypeToString(error)}\n ${result}`;
}
return ErrorPrototypeToString(error);
}
Expand Down
34 changes: 31 additions & 3 deletions test/parallel/test-util-inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,14 +770,14 @@ assert.strictEqual(util.inspect(-5e-324), '-5e-324');
// Note: Symbols are not supported by `Error#toString()` which is called by
// accessing the `stack` property.
[
[404, '404 [RangeError]: foo', '[404]'],
[404, '404 [RangeError]: foo', '[RangeError: foo\n 404]'],
[0, '0 [RangeError]: foo', '[RangeError: foo]'],
[0n, '0 [RangeError]: foo', '[RangeError: foo]'],
[null, 'null: foo', '[RangeError: foo]'],
[undefined, 'RangeError: foo', '[RangeError: foo]'],
[false, 'false [RangeError]: foo', '[RangeError: foo]'],
['', 'foo', '[RangeError: foo]'],
[[1, 2, 3], '1,2,3 [RangeError]: foo', '[[\n 1,\n 2,\n 3\n]]'],
[[1, 2, 3], '1,2,3 [RangeError]: foo', '[RangeError: foo\n [\n 1,\n 2,\n 3\n ]]'],
].forEach(([value, outputStart, stack]) => {
let err = new RangeError('foo');
err.name = value;
Expand Down Expand Up @@ -3457,6 +3457,34 @@ ${error.stack.split('\n').slice(1).join('\n')}`,

assert.strictEqual(
inspect(error),
'[[\n Symbol(foo)\n]]'
'[Error\n [\n Symbol(foo)\n ]]'
);
}

{
const prepareStackTrace = Error.prepareStackTrace;

Error.prepareStackTrace = (error) => error;

const error = new Error('foo');

assert.strictEqual(inspect(error), '[Error: foo\n [Circular *1]]');

Error.prepareStackTrace = prepareStackTrace;
}

{
const error = new Error('foo');
error.stack = error;

assert.strictEqual(inspect(error), '[Error: foo\n [Circular *1]]');
}

{
const error = new Error('foo');
const error2 = new Error('bar');
error.stack = error2;
error2.stack = error;

assert.strictEqual(inspect(error), '[Error: foo\n [Error: bar\n [Circular *1]]]');
}
Loading