Skip to content

worker: update code examples for node:worker_threads module #58264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

worker: update code examples for node:worker_threads module #58264

wants to merge 2 commits into from
+9 −8

Conversation

@fisker
Copy link
Contributor

@fisker fisker commented May 10, 2025 •
edited
Loading

  • Missed one import.
  • Use .once for one time events.
  • Use node:assert/strict instead of node:assert.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels May 10, 2025
jasnell
jasnell reviewed May 12, 2025
View reviewed changes
doc/api/worker_threads.md Outdated
```mjs
import assert from 'node:assert';
import assert from 'node:assert/strict';
Copy link
Member

@jasnell jasnell May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the changes here are ok but this one is generally unnecessary.

Copy link
Contributor Author

@fisker fisker May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d7bcad3 (#58264)

aduh95
aduh95 reviewed Nov 8, 2025
View reviewed changes
doc/api/worker_threads.md
```cjs
'use strict';
const process = require('node:process');
Copy link
Contributor

@aduh95 aduh95 Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CJS snippets usually use the global process

Suggested change
const process = require('node:process');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments

@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fisker @jasnell @aduh95 @nodejs-github-bot