src: fix possible dereference of NULL pointer #58459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58459 +/- ##
==========================================
- Coverage 90.21% 90.19% -0.02%
==========================================
Files 635 635
Lines 187304 187344 +40
Branches 36782 36788 +6
==========================================
+ Hits 168970 168984 +14
- Misses 11093 11140 +47
+ Partials 7241 7220 -21
🚀 New features to boost your workflow:
|
|
Would you mind updating the commit message following https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines? Thank you! |
Eusgor
changed the title
There is a CHECK_NOT_NULL check before dereferencing node_env on line 710 in the "if" block, but there is no CHECK_NOT_NULL check before dereferencing node_env on line 721. Maybe it makes sense to put CHECK_NOT_NULL right after calling the Environment::GetCurrent function.
Eusgor
force-pushed
the
fix-possible-dereference-of-null
branch
from
6025590 to
8c14942
Compare
|
Is everything right now? |
addaleax
approved these changes
May 28, 2025
addaleax
added
request-ci
github-actions
bot
removed
the
request-ci
legendecas
approved these changes
May 29, 2025
mhdawson
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a8e9f63 |
github-project-automation
bot
moved this from Need Triage
to Done
in Node-API Team Project
targos
pushed a commit
that referenced
this pull request
May 31, 2025
There is a CHECK_NOT_NULL check before dereferencing node_env on line 710 in the "if" block, but there is no CHECK_NOT_NULL check before dereferencing node_env on line 721. Maybe it makes sense to put CHECK_NOT_NULL right after calling the Environment::GetCurrent function. PR-URL: #58459 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a CHECK_NOT_NULL check before dereferencing node_env on line 710 in the if block, but there is no CHECK_NOT_NULL check before dereferencing node_env on line 721. Maybe it makes sense to put CHECK_NOT_NULL right after calling the Environment::GetCurrent function?