Skip to content

doc: explain child_process code and signal null values everywhere #58479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RaisinTen
Copy link
Member

@RaisinTen RaisinTen commented May 27, 2025

The child_process documentation already explains when code and signal can be null in the parameters of spawnSync() and the description of exit event. This change now consistently explains this in the close and exit event parameters and descriptions.

Refs: #58463 (comment)

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels May 27, 2025
@RaisinTen
Copy link
Member Author

cc @nodejs/child_process

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 28, 2025
@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2025
@nodejs-github-bot nodejs-github-bot merged commit a984ed3 into nodejs:main May 29, 2025
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a984ed3

@RaisinTen RaisinTen deleted the doc/explain-child-process-code-and-signal-null-values-everywhere branch May 29, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants