lib: fix testNamePatterns and testSkipPatterns being ignored with isolation "none" #58496
Conversation
|
Review requested:
|
nodejs-github-bot
added
needs-ci
| @@ -691,6 +691,17 @@ function run(options = kEmptyObject) { | |||
| cwd, | |||
| globalSetupPath, | |||
| }; | |||
|
|
|||
| if (isolation === 'none') { | |||
There was a problem hiding this comment.
Not sure if it's a good approach. See my comment on the issue: #57399 (comment).
There was a problem hiding this comment.
I think it could be a good starting point, but I agree that at first glance, this solution feels "out of place".
I'll take a look as soon as I can and come back with better feedback 🚀
| @@ -648,6 +648,48 @@ describe('require(\'node:test\').run', { concurrency: true }, () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe("with isolation set to 'none'",() => { | |||
There was a problem hiding this comment.
Each of these tests passes individually, but when the whole describe block is run, the second test hangs indefinitely. I think it has something to do with how tests without isolation work, but I haven't found a fix yet.
There was a problem hiding this comment.
I think it has something to do with how tests without isolation work
As you said, the problem is that the runner is running in the same process as the test file.
This is why you're encountering this issue.
You could follow the same logic used here: https://github.com/nodejs/node/blob/main/test/parallel/test-runner-run-watch.mjs
(Basically, by spawning a process that then calls run with isolation: none)
danielmbrasil
force-pushed
the
fix/test-runner-ignore-patterns-isolation-none
branch
from
9af076f to
9aeef6c
Compare
Fixes #57399.