-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> #58500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
May 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58500 +/- ##
==========================================
+ Coverage 90.20% 90.22% +0.01%
==========================================
Files 635 635
Lines 187616 187595 -21
Branches 36847 36842 -5
==========================================
+ Hits 169234 169249 +15
+ Misses 11150 11130 -20
+ Partials 7232 7216 -16 🚀 New features to boost your workflow:
|
addaleax
approved these changes
May 29, 2025
6ff141b
to
1f2e8ee
Compare
1f2e8ee
to
63d5a26
Compare
legendecas
approved these changes
May 29, 2025
Landed in f497881 |
targos
pushed a commit
that referenced
this pull request
Jun 1, 2025
PR-URL: #58500 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
quic
Issues and PRs related to the QUIC implementation / HTTP/3.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the clean up of std::vector<v8::Local> we did before. Discovered in #58497
From pull request: #57578: