Skip to content

Conversation

StroepWafel
Copy link

Added a confirmation to hopefully discourage people from making useless PRs

Added a confirmation to hopefully discourage people from making useless PRs
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 10, 2025
@targos
Copy link
Member

targos commented Oct 10, 2025

We can do that but I don't think people who make useless PR bother to take time reading the instructions.

@bnb
Copy link
Contributor

bnb commented Oct 10, 2025

I'm actually -1 on this, it's more text that won't meaningfully change anything.

@marco-ippolito
Copy link
Member

marco-ippolito commented Oct 10, 2025

What about an action that closes PR on readme if they dont have a body and invalid commit message?
I created a prototype if anyone likes the idea marco-ippolito@878b6e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants