Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes WiX warnings noticed during the CI builds while creating the installer. Thanks to @targos for pointing me to them. Two main issues were:
The only warning left is this one:
In my opinion, this should stay, as that allows us to install the same version builds over each other. This is useful for development and testing builds, and it has no effect on official releases. I can probably add something in the configuration to suppress it for cleaner logs..
Here is the CI run building it. A flaky test failed there, but the compilation passed.
Fixes: nodejs/build#4130