Skip to content

Conversation

StefanStojanovic
Copy link
Contributor

This PR fixes WiX warnings noticed during the CI builds while creating the installer. Thanks to @targos for pointing me to them. Two main issues were:

  • Using a release candidate version - I've now updated to the latest WiX v4 version (4.0.6)
  • Having a double import of the WiX toolset - I've removed one of them

The only warning left is this one:

C:\workspace\node-compile-windows\node\tools\msvs\msi\nodemsi\product.wxs(26): warning WIX1076: ICE61: This product should remove only older versions of itself. The Maximum version is not less than the current product. (25.0.0 25.0.0) [C:\workspace\node-compile-windows\node\tools\msvs\msi\nodemsi\nodemsi.wixproj]

In my opinion, this should stay, as that allows us to install the same version builds over each other. This is useful for development and testing builds, and it has no effect on official releases. I can probably add something in the configuration to suppress it for cleaner logs..

Here is the CI run building it. A flaky test failed there, but the compilation passed.

Fixes: nodejs/build#4130

@StefanStojanovic StefanStojanovic added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. build Issues and PRs related to build files or the CI. labels Oct 14, 2025
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 14, 2025
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows msi build warnings

6 participants