test: split FFI call and callback coverage - #66287
Merged
Merged
Conversation
Isolate each callback abort scenario so timeouts identify the failing case. Consolidate callback GC coverage in the weakref test and disable core dumps for intentional aborts on POSIX. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
added
the
flaky-test
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
daeyeon
approved these changes
Sep 25, 2026
daeyeon
added
author ready
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66287 +/- ##
==========================================
- Coverage 90.36% 90.35% -0.02%
==========================================
Files 790 790
Lines 273773 273807 +34
Branches 52373 52377 +4
==========================================
- Hits 247399 247394 -5
- Misses 16899 16918 +19
- Partials 9475 9495 +20 🚀 New features to boost your workflow:
|
daeyeon
added
the
resume-ci
panva
removed
the
resume-ci
Collaborator
aduh95
approved these changes
Sep 26, 2026
Collaborator
panva
added
the
commit-queue
ShogunPanda
approved these changes
Sep 27, 2026
Collaborator
|
Landed in a2a064c |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 27, 2026
Isolate each callback abort scenario so timeouts identify the failing case. Consolidate callback GC coverage in the weakref test and disable core dumps for intentional aborts on POSIX. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex PR-URL: #66287 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
HoonDongKang
pushed a commit
to HoonDongKang/node
that referenced
this pull request
Sep 28, 2026
Isolate each callback abort scenario so timeouts identify the failing case. Consolidate callback GC coverage in the weakref test and disable core dumps for intentional aborts on POSIX. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex PR-URL: nodejs#66287 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95
pushed a commit
that referenced
this pull request
Sep 28, 2026
Isolate each callback abort scenario so timeouts identify the failing case. Consolidate callback GC coverage in the weakref test and disable core dumps for intentional aborts on POSIX. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex PR-URL: #66287 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolate each callback abort scenario so timeouts identify the failing case. Consolidate callback GC coverage in the weakref test and disable core dumps for intentional aborts on POSIX.
Assisted-by: Codex