Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup(next.js) 15.2 #7513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

setup(next.js) 15.2 #7513

wants to merge 1 commit into from

Conversation

AugustinMauroy
Copy link
Member

Description

  • updating to next.js 15.2
  • updating react 19 (needed by next.js 15.2)

https://nextjs.org/blog/next-15-2

Related Issues

#7349

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@Copilot Copilot bot review requested due to automatic review settings February 27, 2025 12:50
@AugustinMauroy AugustinMauroy requested review from a team as code owners February 27, 2025 12:50
Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ❌ Failed (Inspect) Feb 27, 2025 0:50am

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates project dependencies to Next.js 15.2 and React 19 while making minor adjustments in configuration and component typings.

  • Updated next.config.ts to use a typed NextConfig.
  • Modified the Avatar component by replacing forwardRef with a functional component definition.

Reviewed Changes

File Description
apps/site/next.config.ts Updated Next.js configuration to provide explicit type checking with NextConfig.
apps/site/components/Common/AvatarGroup/Avatar/index.tsx Replaced forwardRef and ref forwarding in the Avatar component with a functional component using FC type.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

apps/site/components/Common/AvatarGroup/Avatar/index.tsx:27

  • The removal of ref forwarding in the Avatar component may break functionality for consumers relying on ref access. Please verify that no external component depends on forwarding the ref or consider reintroducing forwardRef.
ref={ref}
@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Feb 27, 2025

error occurs (on jest + storybook):

Objects are not valid as a React child (found: object with keys {$$typeof, type, key, props, _owner, _store}). If you meant to render a collection of children, use an array instead.

Next.js built error is Minified React error #31

But Next.js dev working without error

@ovflowd
Copy link
Member

ovflowd commented Feb 27, 2025

Unfortunately we are not compatible with React 19 yet. We need to update a few pieces of code t make it work :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants