Skip to content

chore(logo): update logos, remove unused #7956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Jul 6, 2025

Ref #7880.

This PR updates the logo variants to use the newer icon.

@Copilot Copilot AI review requested due to automatic review settings July 6, 2025 14:36
@avivkeller avivkeller requested a review from a team as a code owner July 6, 2025 14:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Copy link

vercel bot commented Jul 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 8, 2025 8:23pm

Copy link

codecov bot commented Jul 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.68%. Comparing base (ab0ba1d) to head (77ae5e9).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7956      +/-   ##
==========================================
- Coverage   75.36%   73.68%   -1.68%     
==========================================
  Files          96       96              
  Lines        8354     8354              
  Branches      220      219       -1     
==========================================
- Hits         6296     6156     -140     
- Misses       2056     2197     +141     
+ Partials        2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller
Copy link
Member Author

avivkeller commented Jul 6, 2025

If you'd like me to also update the stacked variants in this PR, draft this PR and let me know. (This is separate right now, since updating the stacked logos requires a lot more math.

@MattIPv4
Copy link
Member

MattIPv4 commented Jul 6, 2025

Is there a reason ui-components doesn't just use the same SVGs, rather than a custom component that requires complex maintenance to combine two different SVGs into one?

@MattIPv4
Copy link
Member

MattIPv4 commented Jul 6, 2025

And what's the reasoning for not updating the stacked versions?

@avivkeller
Copy link
Member Author

And what's the reasoning for not updating the stacked versions?

I'm more than happy to, it's just exponentially more math, so I figured it'd be better to get these out, since they are done

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT but what about the component one ?

@avivkeller
Copy link
Member Author

LGMT but what about the component one ?

See the PR description

@AugustinMauroy
Copy link
Member

Is there a reason ui-components doesn't just use the same SVGs, rather than a custom component that requires complex maintenance to combine two different SVGs into one?

/cc @ovflowd you was requiring during 2024 pride month

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Jul 8, 2025
@avivkeller avivkeller enabled auto-merge July 8, 2025 12:36
@avivkeller avivkeller disabled auto-merge July 8, 2025 12:36
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 8, 2025
@avivkeller
Copy link
Member Author

@MattIPv4 @ovflowd Before I merge, just confirming this is okay to land on its own?

@MattIPv4
Copy link
Member

MattIPv4 commented Jul 8, 2025

👍 No objections, but lets make sure we get all the other variants updated too.

@MattIPv4
Copy link
Member

MattIPv4 commented Jul 8, 2025

I'm more than happy to, it's just exponentially more math

Can you expand on this? Is it not just a case of updating the assets in Figma with the cleaned up core Node.js icon, and then re-exporting them?

The Pride variant should be roughly the same process, it uses the core Node.js icon at its core with blend modes applied.

@avivkeller
Copy link
Member Author

Can you expand on this? Is it not just a case of updating the assets in Figma with the cleaned up core Node.js icon, and then re-exporting them?

For these logos, I didn't use Figma, I manually edited the SVGs, as to avoid re-exporting.

@avivkeller avivkeller marked this pull request as draft July 8, 2025 14:03
@avivkeller
Copy link
Member Author

avivkeller commented Jul 8, 2025

I’ll draft this and try and get all public assets in a single PR, as to avoid making branding seem unaligned

@avivkeller avivkeller changed the title chore(logo): update non-stacked public assets chore(logo): update public assets Jul 8, 2025
@avivkeller avivkeller changed the title chore(logo): update public assets chore(logo): update logos, remove unused Jul 8, 2025
@avivkeller
Copy link
Member Author

avivkeller commented Jul 8, 2025

@MattIPv4 Would you be so kind as to handle the pride logo changes in this PR? Feel free to push directly to this branch. All the other logos have been changed. TYSM.

I'm not really an expert UI designer, so I don't want to mis-export your vision.

I'm in the process of updating all the logos (except Pride) in the Figma.

@MattIPv4
Copy link
Member

MattIPv4 commented Jul 8, 2025

👍 Updated them by hand based on the new logos you'd pushed. You should be able to generate a nice diff comparing them against the non-pride versions.

@avivkeller
Copy link
Member Author

Thank you! I'll add the finishing touches (ui-components) and get this to finish line today!

@avivkeller avivkeller marked this pull request as ready for review July 8, 2025 20:22
@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Jul 8, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants