-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore(logo): update logos, remove unused #7956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7956 +/- ##
==========================================
- Coverage 75.36% 73.68% -1.68%
==========================================
Files 96 96
Lines 8354 8354
Branches 220 219 -1
==========================================
- Hits 6296 6156 -140
- Misses 2056 2197 +141
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. |
If you'd like me to also update the stacked variants in this PR, draft this PR and let me know. (This is separate right now, since updating the stacked logos requires a lot more math. |
Is there a reason ui-components doesn't just use the same SVGs, rather than a custom component that requires complex maintenance to combine two different SVGs into one? |
And what's the reasoning for not updating the stacked versions? |
I'm more than happy to, it's just exponentially more math, so I figured it'd be better to get these out, since they are done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT but what about the component one ?
See the PR description |
/cc @ovflowd you was requiring during 2024 pride month |
👍 No objections, but lets make sure we get all the other variants updated too. |
Can you expand on this? Is it not just a case of updating the assets in Figma with the cleaned up core Node.js icon, and then re-exporting them? The Pride variant should be roughly the same process, it uses the core Node.js icon at its core with blend modes applied. |
For these logos, I didn't use Figma, I manually edited the SVGs, as to avoid re-exporting. |
I’ll draft this and try and get all public assets in a single PR, as to avoid making branding seem unaligned |
2a7b6ba
to
0fb7930
Compare
@MattIPv4 Would you be so kind as to handle the pride logo changes in this PR? Feel free to push directly to this branch. All the other logos have been changed. TYSM. I'm not really an expert UI designer, so I don't want to mis-export your vision. I'm in the process of updating all the logos (except Pride) in the Figma. |
👍 Updated them by hand based on the new logos you'd pushed. You should be able to generate a nice diff comparing them against the non-pride versions. |
Thank you! I'll add the finishing touches (ui-components) and get this to finish line today! |
Ref #7880.
This PR updates the logo variants to use the newer icon.