-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat: add End-of-life (EOL) link under About menu #8156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an End-of-Life (EOL) link to the About section of the navigation menu as requested in issue #8155. The change enables users to easily access the EOL releases page from the left navigation panel.
- Added a new "End-of-Life (EOL)" navigation item in the About section
- Added corresponding localization support for the new menu item
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/i18n/src/locales/en.json | Added English localization string for the EOL navigation link |
apps/site/navigation.json | Added new EOL navigation item configuration linking to /eol |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hi @AugustinMauroy @mcollina 👋, I’ve added a link to the End-of-life (EOL) releases page ( Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mohit5Upadhyay . I think it's a bit jarring how we lose the left hand navigation menu
Indeed. Can you change EoL's layout to contain the sidebar by making it use the "about" layout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing against the PR itself, but I'm against this page becoming part of the /about section.
this was called out in the initial implementation. we can figure that part out as part of determining if it should be under about at all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. But the layout of the EOL page needs to change, otherwise it won't render the Sidebar.
Hi @ovflowd @avivkeller @mikeesto 👋,
I’ve updated the PR as per your feedback:
Updated![]() Please take a look whenever you get a chance and let me know if anything else needs adjustment. Thanks again for your guidance! 🙏 |
@Mohit5Upadhyay can you rebase your PR? |
956a0a8
to
f54e1ea
Compare
Hi @ovflowd,
I’ve rebased my PR on top of the latest main and resolved conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good.
note the slight variation of this pattern, because it was not initially within /about/
https://nodejs-org-git-fork-mohit5upadhyay-add-eol-link-openjs.vercel.app/en/eol
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8156 +/- ##
==========================================
- Coverage 76.60% 76.57% -0.04%
==========================================
Files 115 115
Lines 9602 9610 +8
Branches 322 323 +1
==========================================
+ Hits 7356 7359 +3
- Misses 2245 2250 +5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
Hi @bmuenzenmeyer @ovflowd @avivkeller 👋,
I’ve updated all internal references to use Please have a look whenever you get a chance — let me know if anything else needs adjustment. Thanks! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM! Great work, thanks for bearing with our reviews :)
Lighthouse Results
|
Description
This PR is regarding the Issue: #8155 to add a link to the End-of-life (EOL) releases page (
/eol
) in the left navigation under "About".Validation
eol-about-section.mp4
Related Issues
Fixes: #8155
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.