Skip to content

Conversation

Mohit5Upadhyay
Copy link
Contributor

Description

This PR is regarding the Issue: #8155 to add a link to the End-of-life (EOL) releases page (/eol) in the left navigation under "About".

Validation

eol-about-section.mp4

Related Issues

Fixes: #8155

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot AI review requested due to automatic review settings September 6, 2025 07:30
@Mohit5Upadhyay Mohit5Upadhyay requested a review from a team as a code owner September 6, 2025 07:30
Copy link

vercel bot commented Sep 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Sep 18, 2025 5:09pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an End-of-Life (EOL) link to the About section of the navigation menu as requested in issue #8155. The change enables users to easily access the EOL releases page from the left navigation panel.

  • Added a new "End-of-Life (EOL)" navigation item in the About section
  • Added corresponding localization support for the new menu item

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/i18n/src/locales/en.json Added English localization string for the EOL navigation link
apps/site/navigation.json Added new EOL navigation item configuration linking to /eol

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Mohit5Upadhyay
Copy link
Contributor Author

Hi @AugustinMauroy @mcollina 👋,

I’ve added a link to the End-of-life (EOL) releases page (/eol) under the About section in the sidebar, as discussed in issue #8155.
Please review it and let me know if any adjustments are needed.

Thank you!

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mohit5Upadhyay . I think it's a bit jarring how we lose the left hand navigation menu

@avivkeller
Copy link
Member

Indeed. Can you change EoL's layout to contain the sidebar by making it use the "about" layout

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing against the PR itself, but I'm against this page becoming part of the /about section.

@bmuenzenmeyer
Copy link
Collaborator

Indeed. Can you change EoL's layout to contain the sidebar by making it use the "about" layout

this was called out in the initial implementation. we can figure that part out as part of determining if it should be under about at all

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. But the layout of the EOL page needs to change, otherwise it won't render the Sidebar.

@Mohit5Upadhyay
Copy link
Contributor Author

Hi @ovflowd @avivkeller @mikeesto 👋,

Approving. But the layout of the EOL page needs to change, otherwise it won't render the Sidebar.

I’ve updated the PR as per your feedback:

  • Changed the layout of the End-of-Life (EOL) page from article to about, so the left-hand sidebar is now rendered correctly.

Updated

update-eol

Please take a look whenever you get a chance and let me know if anything else needs adjustment.

Thanks again for your guidance! 🙏

@ovflowd
Copy link
Member

ovflowd commented Sep 17, 2025

@Mohit5Upadhyay can you rebase your PR?

@Mohit5Upadhyay
Copy link
Contributor Author

Hi @ovflowd,

@Mohit5Upadhyay can you rebase your PR?

I’ve rebased my PR on top of the latest main and resolved conflicts.
Please review again when you get a chance.
Thanks!

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good.

note the slight variation of this pattern, because it was not initially within /about/
https://nodejs-org-git-fork-mohit5upadhyay-add-eol-link-openjs.vercel.app/en/eol

Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.57%. Comparing base (403fe2d) to head (29ee50b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8156      +/-   ##
==========================================
- Coverage   76.60%   76.57%   -0.04%     
==========================================
  Files         115      115              
  Lines        9602     9610       +8     
  Branches      322      323       +1     
==========================================
+ Hits         7356     7359       +3     
- Misses       2245     2250       +5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mohit5Upadhyay Mohit5Upadhyay requested a review from a team as a code owner September 18, 2025 17:08
Copy link
Contributor

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@Mohit5Upadhyay
Copy link
Contributor Author

Hi @bmuenzenmeyer @ovflowd @avivkeller 👋,

can you look for other eol links and update them to /about/eol?

I’ve updated all internal references to use /about/eol for consistency, as suggested.
Also added the redirect rule to ensure existing /eol links continue to work without breaking.

Please have a look whenever you get a chance — let me know if anything else needs adjustment.

Thanks! 🙏

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM! Great work, thanks for bearing with our reviews :)

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 21, 2025
@ovflowd ovflowd enabled auto-merge September 21, 2025 13:36
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 21, 2025
Copy link
Contributor

github-actions bot commented Sep 21, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 93 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟢 100 🔗
/en/download 🟢 95 🟢 100 🟢 100 🟢 100 🔗
/en/download/archive/current 🟢 100 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a link to eol page in the left menu in About
6 participants