Skip to content

Conversation

@NunoMCP
Copy link

@NunoMCP NunoMCP commented Nov 4, 2025

Docs

Fixes #8326 by parsing the JSON at the final callback and using the status code from the response on the StreamFactoryData

@NunoMCP NunoMCP requested a review from a team as a code owner November 4, 2025 15:13
@vercel
Copy link

vercel bot commented Nov 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Error Error Nov 6, 2025 3:59pm

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (9fbb9f6) to head (ad1a5f1).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8327      +/-   ##
==========================================
+ Coverage   76.72%   76.73%   +0.01%     
==========================================
  Files         118      118              
  Lines        9805     9805              
  Branches      335      335              
==========================================
+ Hits         7523     7524       +1     
+ Misses       2280     2279       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: NunoMCP <[email protected]>
auto-merge was automatically disabled November 6, 2025 15:58

Head branch was pushed to by a user without write access

@mikeesto mikeesto added the github_actions:pull-request Trigger Pull Request Checks label Nov 7, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 7, 2025
Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mikeesto mikeesto enabled auto-merge November 7, 2025 00:48
@NunoMCP
Copy link
Author

NunoMCP commented Nov 7, 2025

Looks like there's a timeout error on one of the E2E tests

  1) [firefox] › tests/e2e/general-behavior.spec.ts:118:5 › Node.js Website › Language › should correctly translate UI elements according to language files 
    Error: page.waitForSelector: Test timeout of 30000ms exceeded.
    Call log:
      - waiting for locator('[aria-labelledby=radix-_R_tpaupivb_]') to be visible


      41 |   await button.click();
      42 |
    > 43 |   await page.waitForSelector(selector);
         |              ^
      44 |   return page.locator(selector);
      45 | };
      46 |
        at openLanguageMenu (/home/runner/work/nodejs.org/nodejs.org/apps/site/tests/e2e/general-behavior.spec.ts:43:14)
        at /home/runner/work/nodejs.org/nodejs.org/apps/site/tests/e2e/general-behavior.spec.ts:124:20

Could this be related to the prettier change? Seems strange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect code example in documentation

3 participants