-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
docs(learn): correct the example code for Streaming Responses with Undici #8327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…onse Signed-off-by: NunoMCP <[email protected]>
Signed-off-by: NunoMCP <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: NunoMCP <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8327 +/- ##
==========================================
+ Coverage 76.72% 76.73% +0.01%
==========================================
Files 118 118
Lines 9805 9805
Branches 335 335
==========================================
+ Hits 7523 7524 +1
+ Misses 2280 2279 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: NunoMCP <[email protected]>
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
Looks like there's a timeout error on one of the E2E tests Could this be related to the prettier change? Seems strange |
Docs
Fixes #8326 by parsing the JSON at the final callback and using the status code from the response on the StreamFactoryData