-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: download page mobile layout spacing #8334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates CSS selectors in the download layout by adjusting the nth-last-child pseudo-class values. The changes modify which sections are targeted by the styles, shifting from the last two sections to the third and fourth sections from the end.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8334 +/- ##
=======================================
Coverage 76.72% 76.72%
=======================================
Files 118 118
Lines 9805 9805
Branches 335 335
=======================================
Hits 7523 7523
Misses 2280 2280
Partials 2 2 ☔ View full report in Codecov by Sentry. |
mikeesto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good change! Although prettier isn't happy
yeah this looks just as prone to brittleness more thorough chromatic visual regression testing could fix this - though i dont think we've used that to stop builds much |
|
Lighthouse Results
|
It seems that the sorting algorithm has changed with version |
Description
With the addition of sponsors on the download page, the order of the sections has changed, which caused the selects to appear too close to each other on mobile viewports. This PR aims to fix that visual issue.
Adding ids to the sections would probably be a better long-term solution, but instead of resetting all existing translations(mdx files), it would make more sense to introduce those ids after a major structural update
Validation
Before
After
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.