Skip to content

Conversation

@canerakdas
Copy link
Member

Description

With the addition of sponsors on the download page, the order of the sections has changed, which caused the selects to appear too close to each other on mobile viewports. This PR aims to fix that visual issue.

Adding ids to the sections would probably be a better long-term solution, but instead of resetting all existing translations(mdx files), it would make more sense to introduce those ids after a major structural update

Validation

Before

image

After

image

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings November 5, 2025 17:37
@canerakdas canerakdas requested a review from a team as a code owner November 5, 2025 17:37
@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Nov 7, 2025 2:53pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates CSS selectors in the download layout by adjusting the nth-last-child pseudo-class values. The changes modify which sections are targeted by the styles, shifting from the last two sections to the third and fourth sections from the end.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.72%. Comparing base (30d6c52) to head (6b8ab7d).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8334   +/-   ##
=======================================
  Coverage   76.72%   76.72%           
=======================================
  Files         118      118           
  Lines        9805     9805           
  Branches      335      335           
=======================================
  Hits         7523     7523           
  Misses       2280     2280           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change! Although prettier isn't happy

@bmuenzenmeyer
Copy link
Contributor

Adding ids to the sections would probably be a better long-term solution, but instead of resetting all existing translations(mdx files), it would make more sense to introduce those ids after a major structural update

yeah this looks just as prone to brittleness

more thorough chromatic visual regression testing could fix this - though i dont think we've used that to stop builds much

@canerakdas canerakdas added the github_actions:pull-request Trigger Pull Request Checks label Nov 7, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟠 88 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 93 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟢 100 🔗
/en/download 🟢 97 🟢 96 🟢 100 🟢 100 🔗
/en/download/archive/current 🟢 100 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@canerakdas
Copy link
Member Author

This looks like a good change! Although prettier isn't happy

It seems that the sorting algorithm has changed with version 0.7.0 of prettier-plugin-tailwindcss. I’ve updated it for this style file, but after this PR, I’ll run a general linter check to see if there are other places in the project that need updating as well 🙌

@avivkeller avivkeller added this pull request to the merge queue Nov 7, 2025
Merged via the queue into nodejs:main with commit 47a6c9f Nov 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants