WIP

lib/handler/cache-handler.js

@@ -7,6 +7,8 @@ const {
   parseVaryHeader
 } = require('../util/cache')
 
+function noop () {}
+
 /**
  * Writes a response to a CacheStore and then passes it on to the next handler
  */
@@ -77,15 +79,11 @@ class CacheHandler extends DecoratorHandler {
       // Try/catch for if it's synchronous
       try {
         const result = this.#store.deleteByOrigin(this.#requestOptions.origin)
-        if (
-          result &&
-          typeof result.catch === 'function' &&
-          typeof this.#handler.onError === 'function'
-        ) {
+        if (typeof result?.catch === 'function') {
           // Fail silently
-          result.catch(_ => {})
+          result.catch(noop)
         }
-      } catch (err) {
+      } catch {
         // Fail silently
       }
 
@@ -139,6 +137,7 @@ class CacheHandler extends DecoratorHandler {
       if (this.#writeStream) {
         this.#writeStream.on('drain', resume)
         this.#writeStream.on('error', () => {
+          // TODO (fix): Make this error somehow observable?
           this.#writeStream = undefined
           resume()
         })
@@ -148,6 +147,7 @@ class CacheHandler extends DecoratorHandler {
     if (typeof this.#handler.onHeaders === 'function') {
       return downstreamOnHeaders()
     }
+
     return false
   }
 
@@ -178,10 +178,7 @@ class CacheHandler extends DecoratorHandler {
    */
   onComplete (rawTrailers) {
     if (this.#writeStream) {
-      if (rawTrailers) {
-        this.#writeStream.rawTrailers = rawTrailers
-      }
-
+      this.#writeStream.rawTrailers = rawTrailers ?? []
       this.#writeStream.end()
     }