Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pluralizer #3586

Merged
merged 2 commits into from
Sep 12, 2024
Merged

chore: remove pluralizer #3586

merged 2 commits into from
Sep 12, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 12, 2024

We dont use the pluralizer that excessive, even though it is in the codebase for more than 2 years. I think this means that it did not had the desired impact.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 070323c into nodejs:main Sep 12, 2024
32 checks passed
@Uzlopak Uzlopak deleted the rewrite-pluralizer branch September 12, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants