fetch: make consumeBody sync #3606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
commented
Sep 13, 2024
Comment on lines
426
to
+432
| if (bodyUnusable(object)) { | ||
| throw new TypeError('Body is unusable: Body has already been read') | ||
| return Promise.reject(new TypeError('Body is unusable: Body has already been read')) | ||
| } | ||
|
|
||
| throwIfAborted(object[kState]) | ||
| if (object[kState].aborted) { | ||
| return Promise.reject(new DOMException('The operation was aborted.', 'AbortError')) | ||
| } |
There was a problem hiding this comment.
Actually I thin aborted is a subtype of the object being unusable. Does it have to be a DOMException?
KhafraDev
requested changes
Sep 14, 2024
|
Despite saving one promise i also dislike the try catch. Retractng. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consumeBody does not need to be async.