Fix version checking for Debian repo for future versions. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtpereira This looks great, would be nice if you based it on master rather than my branch? So I can merge it there. Cheers. |
| @@ -1,3 +1,4 @@ | |||
| --- | |||
| # vars file for nodejs | |||
| debian_repo_version: "{{ nodejs_version }}" | |||
| nodejs_old_versions: ['0.10', '0.12'] | |||
There was a problem hiding this comment.
Can we come up with another name for this?
Like zero_versions?
Cheers
|
Hello, Ok, I'll fix those things. My thinking on opening a PR to your feature branch was that you could merge it your branch, adapt as you see fit and then carry on with merging the original PR. As for the variable, I always feel safer my prepending every var name with the name of the role, in order to avoid collisions. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
With this solution, new versions of Node will be covered, assuming that the repo naming convention sticks.
What do you think @wolfeidau? Does this fix #19 ?