feat: Port callstack resolution from aztec to noirjs #7642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: chore: update yarn version to 4.5.2 (#7678) chore: migrate to use new flat eslint config file (#7676) chore: bump JS dependencies (#7669) chore: bump wasm-pack to 0.13.1 (#7675) chore: bump node to v22.18.3 (#7668) chore!: make `ResolverError::UnnecessaryPub` a hard error (#7664) fix: correctly format let followed by comment before unsafe (#7659) chore: bump external pinned commits (#7667) chore: fixing timeouts (#7666) chore(ssa): Do not print entire functions in underconstrained values check trace (#7665) chore(ci): Exclude enum tests from Brillig reports (#7661) chore: add regression tests for PR #7570 from lambda interpreter test (#7638) chore: remove some unused HIR code (#7643) chore: update examples to use UltraHonk (#7653) fix: allow method call after block, if and match (#7655) chore: address recurring typo in docs (#7656) fix(ssa): don't check Brillig calls for coverage if they don't return anything (e.g. println) (#7644) chore: bump external pinned commits (#7640)
|
Looks like there's a bunch of type errors here. Can look at it later. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: ea205b1 | Previous: 6723aec | Ratio |
|---|---|---|---|
zkemail_noir-jwt_ |
5 s |
2 s |
2.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
Oh, they are not caught by CI? |
|
Seems like it wasn't |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
NoirJS didn't resolve noir callstacks, which is important to give the same devex when using JS tooling as when using nargo.
Summary*
Adds callstack resolution to noir js, which was missing. The code has been ported from the aztec codebase.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.