feat(mo): add moRealVectorNeighbor for continuous local search#83
feat(mo): add moRealVectorNeighbor for continuous local search#83evvaletov wants to merge 1 commit intonojhan:masterfrom
Conversation
dd0e4c0 to
147d1db
Compare
|
Hi! Thanks for the contributions, it's really welcomed! However, I cannot do a code review, because the PR contains almost all Paradiseo history, which completely breaks Github's review feature. Can you make a new branch from HEAD, cherry-pick your contributions in two commits and then force push on the PR branch? |
|
From the content description, here is what I can say:
About this last remark: Paradiseo is designed so that you can always assemble atomic operators to make one with broader feature set. Here, you want to make a continuator (or maybe just a monitor? I'm not sure) with two features. The right approach would thus be to combine the operator counting seconds with the one counting generations, not to have a new one that combine the two. Once understood, you will be able to combine even more continuators/monitors... That's the beauty of Paradiseo :-) |
moRealVectorNeighbor: neighbor type for real-valued vector solutions with delta-based forward/backward moves via moBackableNeighbor.
147d1db to
bf9f093
Compare
|
You're right, the continuator is a composition problem, not a new class. I've removed The PR now contains only I've also rebased onto HEAD so the diff is reviewable. Sorry about the history mess: the fork had a divergent merge commit from 2013 that gave every subsequent commit a different SHA. |
nojhan
left a comment
There was a problem hiding this comment.
Awesome. Only very minor comments, the code is good.
| /* | ||
| <moRealVectorNeighbor.h> | ||
| Copyright (C) DOLPHIN Project-Team, INRIA Lille - Nord Europe, 2006-2010 | ||
| (C) OPAC Team, LIFL, 2002-2007 |
There was a problem hiding this comment.
This header is at least wrong on the dates. And there should be only one copyright mention.
| knowledge of the CeCILL license and that you accept its terms. | ||
|
|
||
| ParadisEO WebSite : http://paradiseo.gforge.inria.fr | ||
| Contact: paradiseo-help@lists.gforge.inria.fr |
There was a problem hiding this comment.
Website and contact are also wrong (maybe this will be fixed by PR #88 ?).
| #include <ostream> | ||
|
|
||
| /** | ||
| * Neighbor for real-valued vector solutions. |
There was a problem hiding this comment.
Needs an empty line after the summary line.
Summary
Adds
moRealVectorNeighbor(mo/src/neighborhood/): a neighbor type forreal-valued vector solutions with delta-based forward/backward moves via
moBackableNeighbor. Follows the same<EOT, Fitness>template conventionas
moIndexNeighbor.Motivation
Paradiseo's MO module has neighbor types for index-based and bit-based
representations but nothing for real-valued vectors.
moRealVectorNeighboris needed by the real-valued neighborhood explorerin a follow-up PR (#87).
Changes
mo/src/neighborhood/moRealVectorNeighbor.hAdditive only — no existing files modified.