fix tests

nokia · Jul 12, 2024 · 996fc8c · 996fc8c
1 parent dea1dc0
commit 996fc8c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/moler/helpers.py b/moler/helpers.py
@@ -414,6 +414,9 @@ def convert_to_number(value, none_if_cannot_convert: bool = False):
             except ValueError:
                 if none_if_cannot_convert:
                     return None
+    else:
+        if none_if_cannot_convert:
+            return None
     return value
 
 

diff --git a/test/test_helpers.py b/test/test_helpers.py
@@ -318,10 +318,10 @@ def test_convert_to_number_str():
 def test_convert_to_number_str_none():
     from moler.helpers import convert_to_number
     expected = "not a number"
-    result = convert_to_number(expected)
-    assert expected == result
-    result = convert_to_number(expected, True)
-    assert result is None
+    result1 = convert_to_number(expected, False)
+    assert expected == result1
+    result2 = convert_to_number(expected, True)
+    assert result2 is None
 
 
 def test_escape_cursors():