Skip to content

Formatting and best practices#1

Open
andrlime wants to merge 5 commits intomainfrom
formatting
Open

Formatting and best practices#1
andrlime wants to merge 5 commits intomainfrom
formatting

Conversation

@andrlime
Copy link
Copy Markdown
Member

  1. You didn't use logo.svg after importing it, might as well remove because it's pointless
  2. In background it was <div ... > with a space at the end and in foreground is was <div ...> with no space, this should probably be consistent otherwise it looks weird
  3. Component files should be capitalized, so background should be Background

@echavemann
Copy link
Copy Markdown
Member

look at andrew caring about the applicant experience!!

Copy link
Copy Markdown
Member

@egelja egelja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants