feat: sync Nota XNNPACK with Google upstream#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nota-github/XNNPACKonto currentgoogle/XNNPACKmasteratf45b3ea023012bd29deaa1900272933bca798ab5.QD8/F16/QB4WGEMM config fix on top asf8d2ca0a2efbb9c97da9039933960748ebc6b2dc.Background
The previous Nota fork head was based on Google XNNPACK
f0b3a2996d6fff82cd3f004c0b29f5ccb0ab947dand carried a custom fix forxnn_init_qd8_f16_qb4w_gemm_config().Current Google
masterstill gates that getter onqd8_f16_qb4w_gemm_config.arch, whileinit_qd8_f16_qb4w_gemm_config()does not assign.archon its Arm branches. The original failure therefore remains present upstream: supported Arm hardware can receive a null GEMM config and fail runtime creation withxnn_status_unsupported_hardware.The custom change is replayed after the upstream rebase and still returns the initialized config unconditionally, matching the
qd8_f16_qc4wsibling behavior.Test plan
git rev-list --left-right --count upstream/master...HEAD->0 1git diff --check upstream/master...HEAD.archreturn guard and no corresponding.archassignment in the initializer.