chore: clean up leftover config.ratify.deislabs.io ClusterRole rules - #2829
Closed
fseldow wants to merge 1 commit into
Closed
chore: clean up leftover config.ratify.deislabs.io ClusterRole rules#2829fseldow wants to merge 1 commit into
fseldow wants to merge 1 commit into
Conversation
The manager ClusterRole still granted full CRUD on the legacy v1 config.ratify.deislabs.io resources (certificatestores, policies, stores, verifiers and their namespaced variants). Those CRDs and their controllers no longer exist in Ratify v2, so the rules are dead grants and are removed to keep the manager least-privilege. This matches what controller-gen (make manifests) produces from the current markers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fseldow
requested review from
akashsinghal,
binbin-li,
jimmyraywv,
luisdlp,
susanshi and
toddysm
as code owners
July 27, 2026 03:10
Contributor
There was a problem hiding this comment.
Pull request overview
Removes obsolete RBAC permissions from the controller manager ClusterRole by dropping rules that granted CRUD access to legacy config.ratify.deislabs.io (v1) resources that no longer exist in Ratify v2, reducing unnecessary privilege scope.
Changes:
- Removed all
config.ratify.deislabs.ioresource rules (including/statusand/finalizers) fromconfig/rbac/role.yaml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2829 +/- ##
=======================================
Coverage 76.36% 76.36%
=======================================
Files 88 88
Lines 3999 3999
=======================================
Hits 3054 3054
Misses 799 799
Partials 146 146 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fseldow
changed the title
Contributor
Author
|
Superseded by #2832, opened from a fork following the standard contribution flow. The branch pushed directly to the upstream repo has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The manager
ClusterRole(config/rbac/role.yaml) still grants full CRUD on the legacy v1config.ratify.deislabs.ioresources —certificatestores,policies,stores,verifiersand theirnamespaced*variants (plus/finalizersand/status).These CRDs and their controllers no longer exist in Ratify v2, so the grants are dead and unnecessarily widen the manager's privileges. This removes them, which is also exactly what
controller-gen(make manifests) produces from the current kubebuilder RBAC markers.This is a pure cleanup with no functional change, split out of #2827 so that PR's RBAC diff stays limited to the new per-pod permissions.
Testing
grep deislabs config/rbac/role.yaml→ no matches after the change.Refs #2797, #2827.