Skip to content

Change serialization of SyncFrom to NULL #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

taco-indenbosch
Copy link

I changed the serialization of the SyncFrom property from Javascript's undefined to null as required by the API. Without it new synchronized blocks cannot be created.

Description

The NullValueHandling = NullValueHandling.Include argument to the JsonProperty attribute ensures that .NET null values are serialized as Javascript null values instead of undefined. The Notion API requires the sync_from property to be null for new synced blocks.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I am using the Notion.NET library to upload converted data to Notion. Since this change I have been able to create synced blocks, both new and linking to existing ones.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

I changed the serialization of the SynFrom property from Javascript's
undefined to null as required by the API. Without it new synchronized
blocks cannot be created.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for your first pull request! The team will review it shortly. We’re excited to have you contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant