Change serialization of SyncFrom to NULL #465
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the serialization of the SyncFrom property from Javascript's undefined to null as required by the API. Without it new synchronized blocks cannot be created.
Description
The
NullValueHandling = NullValueHandling.Include
argument to the JsonProperty attribute ensures that .NETnull
values are serialized as Javascriptnull
values instead ofundefined
. The Notion API requires thesync_from
property to benull
for new synced blocks.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I am using the Notion.NET library to upload converted data to Notion. Since this change I have been able to create synced blocks, both new and linking to existing ones.
Checklist: