Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make possible to sign transactions without state machine #2188

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Dmitry-Borodin
Copy link
Contributor

@Dmitry-Borodin Dmitry-Borodin commented Nov 16, 2023

Purpose

  1. Make it possible to get and sign transactions without state machine - last peace why we need it
  2. Remote state machine from rust and clients

Scope

Looks like it's doable job, work in progress.
Need to cleanup and maybe move signing logic to another crate when it's working.

Added API last peace of state-machine used

pub fn sign_transaction(
pub fn get_transaction(

TODOs

  • finish signing - it's in comments what should be done there
  • Move signing logic to more appropriate place
  • describe api with uniffi
  • adopt android and remove state machine
  • adopt ios and remove state machine
  • remove state machine from rust

Discussion

Move signing logic from lib.rs, where?

@Dmitry-Borodin Dmitry-Borodin marked this pull request as draft November 16, 2023 08:55
@Dmitry-Borodin Dmitry-Borodin changed the title feat: make possible to sign transactions without state machinework in progress - make transactions signing possible without state m… feat: make possible to sign transactions without state machine Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant