Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS build to use newer vulkan #604

Merged
merged 9 commits into from
Feb 13, 2025
Merged

Conversation

capnkenny
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fixes the macOS workflow to ensure that Vulkan continues to install properly.

Is there an open issue that this resolves? If so, please link it here.
No

What is the current behavior? (You can also link to an open issue here)
Workflow fails

What is the new behavior (if this is a feature change)?
Workflow succeeds

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Copy link

github-actions bot commented Feb 11, 2025

Test Results

   10 files  +    4     10 suites  +4   5m 44s ⏱️ + 3m 10s
  693 tests ±    0    693 ✅ ±    0  0 💤 ±0  0 ❌ ±0 
6 930 runs  +2 772  6 930 ✅ +2 772  0 💤 ±0  0 ❌ ±0 

Results for commit ca5294e. ± Comparison against base commit 5ad1ba6.

♻️ This comment has been updated with latest results.

@capnkenny capnkenny marked this pull request as ready for review February 12, 2025 03:48
@capnkenny capnkenny requested a review from RubyNova February 12, 2025 03:48
@RubyNova RubyNova enabled auto-merge February 13, 2025 00:06
Copy link
Member

@RubyNova RubyNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RubyNova RubyNova merged commit 9032dd4 into main Feb 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants