mpsl: clock_ctrl: Add MRAM high frequency request to MPSL #20532
+172
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: e2250c7a4bbc8d154f9ff4ee4a0dc1be5f78a643 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: aedb4c0245 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
ppryga-nordic
force-pushed
the
mpsl-clock-ctrl-request-gd-320mhz
branch
from
8c9e4bf to
faeb332
Compare
AyturkDuzen
reviewed
Feb 20, 2025
AyturkDuzen
reviewed
Feb 20, 2025
ppryga-nordic
force-pushed
the
mpsl-clock-ctrl-request-gd-320mhz
branch
2 times, most recently
from
70d4eb3 to
9187eaf
Compare
|
I've added small change to make the frequency more portable/safe. Instead of using a frequency index and |
Mirlenko
requested changes
Feb 21, 2025
nordicjm
reviewed
Feb 21, 2025
subsys/mpsl/clock_ctrl/Kconfig
Outdated
Comment on lines
20
to
22
| int "" | ||
| default CLOCK_CONTROL_NRF2_NRFS_CLOCK_TIMEOUT_MS if CLOCK_CONTROL_NRF2 | ||
| default 1000 |
There was a problem hiding this comment.
there is a prompt but the prompt is empty, this is not right. If this should not be user adjustable, drop the prompt
ppryga-nordic
force-pushed
the
mpsl-clock-ctrl-request-gd-320mhz
branch
from
9187eaf to
203931a
Compare
In the nRF54h20 SoC the non-volatile memory is located in a global domain which by default configured by nrf2 clock control to run with 64MHz. That makes a code execution time longer so it doesn't fit into radio protocols time requirements. That causes e.g. Bluetooth stack to assert in radio events. To make sure the clock needed for MRAM (non-volatile memory in nRF54h20 SoC) is always setup to highest avaialble frequency MPSL will put a request for the clock to clock control driver. In case there is any other user of the clock that runs from radio core and allows to lower the global domain clock frequency, the clock will still be stay as requested by MPSL. Signed-off-by: Piotr Pryga <[email protected]>
ppryga-nordic
force-pushed
the
mpsl-clock-ctrl-request-gd-320mhz
branch
from
203931a to
e2250c7
Compare
Mirlenko
approved these changes
Feb 21, 2025
AyturkDuzen
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the nRF54h20 SoC the non-volatile memory is located in a global domain which by default configured by nrf2 clock control to run with 64MHz. That makes a code execution time longer so it doesn't fit into radio protocols time requirements. That causes e.g. Bluetooth stack to assert in radio events.
To make sure the clock needed for MRAM (non-volatile memory in nRF54h20 SoC) is always setup to highest avaialble frequency MPSL will put a request for the clock to clock control driver. In case there is any other user of the clock that runs from radio core and allows to lower the global domain clock frequency, the clock will still be stay as requested by MPSL.