Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarantine_zephyr: Enabled zephyr mesh sample again #20535

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

m-alperen-sener
Copy link
Contributor

Fixed here: 1883f06

@m-alperen-sener m-alperen-sener requested a review from a team as a code owner February 20, 2025 13:56
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 20, 2025
@m-alperen-sener m-alperen-sener changed the title Enabled zephyr mesh sample again quarantine_zephyr: Enabled zephyr mesh sample again Feb 20, 2025
@m-alperen-sener m-alperen-sener removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 20, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 20, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: eff7f39a7a31497c54edecd3d27bfecd0bd53737

more details

sdk-nrf:

PR head: eff7f39a7a31497c54edecd3d27bfecd0bd53737
merge base: ae518d055670fcca964fbe0f10809a4dd4481e8b
target head (main): 96683e2782923209e3f4bb9e6e0b48db770afee7
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
scripts
│  │ quarantine_zephyr.yaml

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@m-alperen-sener m-alperen-sener added the ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. label Feb 20, 2025
@m-alperen-sener m-alperen-sener force-pushed the enabled_zephyr_mesh_sample_again branch from d29fad6 to eff7f39 Compare February 20, 2025 14:50
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. and removed ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. labels Feb 20, 2025
@m-alperen-sener m-alperen-sener added ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. CI-run-zephyr-twister and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 20, 2025
@PerMac
Copy link
Contributor

PerMac commented Feb 21, 2025

looks like CI error, the run is marked as successful in jenkins, but not on github. cc @jangalda-nsc

@thst-nordic
Copy link
Contributor

thst-nordic commented Feb 21, 2025

looks like CI error, the run is marked as successful in jenkins, but not on github. cc @jangalda-nsc

Run#3 was triggered with 'RUN_DOWNSTREAM' turned off.
We return 'COMPLETED/CANCELED' in this situation to make sure the PR doesn't merge without HW testing.

I've started run#4, it should pass soon with no code changes.

@PerMac
Copy link
Contributor

PerMac commented Feb 21, 2025

I guess this must be some error within the workflow/ not synchronized features. I think the idea was that if only quarantine is changed there is no need for downstream jobs
"We return 'COMPLETED/CANCELED' in this situation to make sure the PR doesn't merge without HW testing." maybe this policy should be updated as well?

@DatGizmo
Copy link
Contributor

I guess this must be some error within the workflow/ not synchronized features. I think the idea was that if only quarantine is changed there is no need for downstream jobs "We return 'COMPLETED/CANCELED' in this situation to make sure the PR doesn't merge without HW testing." maybe this policy should be updated as well?

There is a difference between, downstream skipped because they are not needed, and RUN_DOWNSTERAM == false
The first is detected by the system, so success can be sent to GH
The latter is a user input, so we don't know if the downstreams should have been executed, there fore we sent Canceled to prevent the PR from merging.

@m-alperen-sener
Copy link
Contributor Author

Well I was trying to trigger the tests on twister; what I wanted to do was to run the tests I am enabling. It seems I did something wrong along the way.

Well I have no problem locally when I run the tests. We can merge as it is then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. CI-run-zephyr-twister
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants