-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce scripts twister extended #20544
base: main
Are you sure you want to change the base?
Introduce scripts twister extended #20544
Conversation
After documentation is built, you will find the preview for this PR here. Preview links for modified nRF Connect SDK documents: |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 654d0940720c688339f1aeab95eb0f5bb94b1669 more detailssdk-nrf:
Github labels
List of changed files detected by CI (13)
Outputs:ToolchainVersion: aedb4c0245 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
@nrfconnect/ncs-ll-ursus this approach can be more easy to use than alt config. With this approach it will be also easy to add it globally into CI, not only LL. |
485737c
to
c2df84d
Compare
@nrfconnect/ncs-co-build-system do you know if a prj.conf from original source can be linked without the need to copy it? |
|
I was thinking about solution described at 2 ie. did not find sth better. |
integration_platforms: | ||
- nrf54l20pdk/nrf54l20/cpuapp | ||
harness: console | ||
harness_config: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can use base prj.conf with
extra_args:
- EXTRA_CONF_FILE=boards/nrf54l20pdk_nrf54l20_cpuapp.conf
- CONF_FILE="${ZEPHYR_base}/samples/subsys/settings/prj.com"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added CONF_FILE as you suggested, thus prj.conf now are taken from original place by default, thus maintenance should be easier, thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like adding CONF_FILE makes other conf and overlays (from boards) not applied. thus, for simplicity, I will stay with copying proj.conf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it very wrong to start placing CMakeLists.txt, conf file, overlays, etc under: scripts/twister/extended
.
This is really messing up where to find things.
We should have some dedicated test folder location.
if tests
cannot be used directly due to naming conflicts, then perhaps tests/extend
.
I'm open for alternatives, but definitely not under scripts
.
There is already accepted by Carles location for very similar things - alt-configs - at https://github.com/nrfconnect/sdk-nrf/tree/main/scripts/twister/alt, thus I created my "extenstion" here. We want to keep structure of tests and samples exact as in zephyr, thus we cannot use nrf/tests or nrf/samples for that, as this will make more chaos. Please note that this is only done to make testing faster, we do not want to expose that we support those tests and samples in this way - at the end, they should be officially added for support at zephyr. Then this, a little bit hidden folder, is IHMO very good place. |
d214145
to
4c06914
Compare
a277d91
to
553f862
Compare
553f862
to
e3bf935
Compare
Extend configuration for zephyr/samples/sensor/qdec for nrf54L20. Signed-off-by: Piotr Kosycarz <[email protected]>
…f54L20 Extend configuration for zephyr/samples/subsys/settings for nrf54L20. Signed-off-by: Piotr Kosycarz <[email protected]>
Initially ncs-low-level-test. Signed-off-by: Piotr Kosycarz <[email protected]>
ci_samples_sensor_qdec ci_samples_subsys_settings Signed-off-by: Piotr Kosycarz <[email protected]>
Add dependency for LL testing. Signed-off-by: Piotr Kosycarz <[email protected]>
e3bf935
to
654d094
Compare
This is an extension for aligning zephyr tests for new platforms, which are under preparation, especially those at pre-silicon stage.
For that we want to enable multiple tests which can allow as to validate HW more.
Extending them at native zephyr is slow and adds additional, unwanted process complexity.
This approach allows to do small adjustments for samples/tests - like editing sample/testcase.yaml, adding overlays and confs. Will not edit code in this way, thus fixes and adjustments in the drivers should be done directly at zephyr.