Fixes for multi antenna CS on nrf54h20 #24757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NordicBuilder
added
the
changelog-entry-required
Contributor
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 34fb1e782ce5f4a301494c0ba6c9c7ce09a20c69 more detailssdk-nrf:
Github labels
List of changed files detected by CI (4)Outputs:ToolchainVersion: a7529a11f4 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
This change is made because the Zephyr GPIO driver API cannot be used from interrupt context as it may block when CONFIG_PM_DEVICE_RUNTIME=y (this happens on nrf54h20). When CONFIG_PM_DEVICE_RUNTIME=y we make sure that the pins are always powered by manually calling `pm_device_runtime_get` in `cs_antenna_switch_init` and `pm_device_runtime_put` in `cs_antenna_switch_clear`. This is probably not optimal when it comes to power consumption. Unfortunately cs_antenna_switch.c is now using a hybrid solution for gpios, where we use zephyr gpio driver to configure the pins, `gpio_pin_configure_dt` and nrf_gpio API `nrf_gpio_port_pin_write` to actually set the value of pins. Signed-off-by: Erik Sandgren <[email protected]>
Enable the correct instances of gpio and gpiote on nrf54h20 for the CS RAS initiator and reflector. This is required for building the samples with CONFIG_BT_CTLR_SDC_CS_MULTIPLE_ANTENNA_SUPPORT=y Signed-off-by: Erik Sandgren <[email protected]>
eriksandgren
force-pushed
the
multi_antenna_cs_on_nrf54h20
branch
from
3c8093f to
34fb1e7
Compare
thomas-m-johansen
approved these changes
Oct 2, 2025
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.