-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Enable PSA RNG for nrf54h20 #24932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable PSA RNG for nrf54h20 #24932
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 3aab7615900c157eccca4754bcf97cd0e4e5da9c more detailssdk-nrf:
zephyr:
Github labels
List of changed files detected by CI (23)Outputs:ToolchainVersion: 46667c6630 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
971746f to
feb192f
Compare
feb192f to
7212518
Compare
7212518 to
881bdce
Compare
|
You can find the documentation preview for this PR here. |
2369a9b to
b47e11b
Compare
8f7b070 to
ba2cc15
Compare
|
Ping @nrfconnect/ncs-co-build-system @nrfconnect/ncs-code-owners @nrfconnect/ncs-si-bluebagel |
ba2cc15 to
6fe9cd6
Compare
|
@nrfconnect/ncs-dragoon Please have a look on this, only the last commit should be relevant to you. |
| select NRF_SECURITY | ||
| select MBEDTLS_PSA_CRYPTO_C | ||
| select MBEDTLS_ENABLE_HEAP | ||
| select MBEDTLS_PSA_CRYPTO_C if !DT_HAS_NORDIC_IRONSIDE_CALL_ENABLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we allow building with TFM_PROFILE_TYPE_MINIMAL if DT_HAS_NORDIC_IRONSIDE_CALL_ENABLED is set (as IronSide handles the crypto calls then)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we select CONFIG_PSA_CRYPTO instead of MBEDTLS_PSA_CRYPTO_C ? (or maybe selecting only the NRF_SECURITY would be sufficient here as it has select PSA_CRYPTO)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we allow building with TFM_PROFILE_TYPE_MINIMAL if DT_HAS_NORDIC_IRONSIDE_CALL_ENABLED is set (as IronSide handles the crypto calls then)?
TF-M is not supported in Ironside enabled devices at all. I am not sure how/if this is enforced at the moment but hopefully it is another task to make sure that this is not allowed at all.
Shouldn't we select CONFIG_PSA_CRYPTO instead of MBEDTLS_PSA_CRYPTO_C ? (or maybe selecting only the NRF_SECURITY would be sufficient here as it has select PSA_CRYPTO)
Yeah, my thinking was that since NRF_SECURITY enables it already we don't also need to do it here.
Dragoon is not an owner of any file in this PR, you have the sufficient approvals. |
In any case, it looks good to me as a Dragooner. Thanks for the heads-up. |
a7fbace to
8b1bb88
Compare
8b1bb88 to
13700c3
Compare
Automatically created by Github Action Signed-off-by: Nordic Builder <[email protected]>
Make sure that the PSA_CORE_DISABLED is always selected and is the only available option for the Ironside enabled devices. Signed-off-by: Georgios Vasilakis <[email protected]>
Enable NRF_SECURITY by default when the PSA RNG is enabled with the Ironside devices. I also refactored the previous logic to avoid duplications in the default statements. Signed-off-by: Georgios Vasilakis <[email protected]>
Ironside is a provider of PSA services (including storage) so it cannot be used along with the trusted storage subsystem which provides PSA storage APIs. Signed-off-by: Georgios Vasilakis <[email protected]>
Enable the option PSA_CRYPTO when NRF_SECURITY is enabled. This will make it possible to select different providers for PSA crypto APIs, one provider being MbedTLS, another is TF-M and a custom one could be used as well. Since nrf_security provides PSA crypto APIs it sets the custom provider as default. Signed-off-by: Georgios Vasilakis <[email protected]>
The default entropy device for nRF54H20 now uses PSA APIs from Ironside. This is incompatible with Oberon so disable it in the test. Signed-off-by: Georgios Vasilakis <[email protected]>
When Ironside is enabled direct access to the crypto APIs is not possible. Add the relevant dependencies of the Ironside to the BT_FAST_PAIR options. Signed-off-by: Georgios Vasilakis <[email protected]>
13700c3 to
3aab761
Compare
This PR enables the PSA RNG as the default random provider for nRF54h20. Please see commits for details