-
Notifications
You must be signed in to change notification settings - Fork 1.4k
wifi: Fix issues with peer authorization #25902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses WiFi peer authorization issues in STA and SoftAP modes by updating dependency versions and adjusting network buffer configuration. The fixes are primarily delivered through updates to the zephyr and nrfxlib dependencies.
- Updates zephyr and nrfxlib to pull in authorization fixes from upstream PRs
- Adds network packet buffer configuration to the promiscuous WiFi sample
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| west.yml | Updates zephyr revision to pull/3557/head and nrfxlib revision to pull/1941/head to incorporate authorization fixes |
| samples/wifi/promiscuous/prj.conf | Adds CONFIG_NET_PKT_BUF_RX_DATA_POOL_SIZE=20000 to configure RX data pool buffer size |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
west.yml
Outdated
| - name: zephyr | ||
| repo-path: sdk-zephyr | ||
| revision: 56fbb4f3c7bba12fb34a5cd111b4ea9f7ad52162 | ||
| revision: pull/3557/head |
Copilot
AI
Nov 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using pull request references (e.g., pull/3557/head) as revision values is not recommended for production manifests. Pull request branches can be rebased, force-pushed, or deleted after merge, making builds non-reproducible. Consider using specific commit SHAs instead. Once the referenced PRs are merged, this should be updated to point to the actual merged commit SHA.
| revision: pull/3557/head | |
| revision: <MERGED_COMMIT_SHA> |
west.yml
Outdated
| repo-path: sdk-nrfxlib | ||
| path: nrfxlib | ||
| revision: 5b0b19946f2bb47cfa4aa358322146edee38cbd5 | ||
| revision: pull/1941/head |
Copilot
AI
Nov 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using pull request references (e.g., pull/1941/head) as revision values is not recommended for production manifests. Pull request branches can be rebased, force-pushed, or deleted after merge, making builds non-reproducible. Consider using specific commit SHAs instead. Once the referenced PRs are merged, this should be updated to point to the actual merged commit SHA.
| revision: pull/1941/head | |
| revision: <MERGED_COMMIT_SHA> |
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: bd31b7f67b2b98b8ea35c86f50333785362b4ce1 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: 43683a87ea Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. |
|
Please rebase, nrfxlib was updated to the latest revision in other PR. |
|
Actually, sdk-zephyr was updated to latest as well, so please keep the sample commit only. |
Increase RX data pool to fix data buffer allocation failures. Fixes SHEL-3917. Signed-off-by: Triveni Danda <[email protected]>
Make PMF optional by default instead of forcing it disabled when not configured. Signed-off-by: Triveni Danda <[email protected]>
Without scan_ssid, the STA sends a broadcast probe and relies on filter_ssid to match results. Since filter_ssid is not used, scan_ssid must be enabled to explicitly scan for the configured SSID. Signed-off-by: Triveni Danda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes issue in STA and SoftAP modes.
test_chip: PR-1094
Jira: https://nordicsemi.atlassian.net/browse/SHEL-3931