Skip to content

Conversation

@krish2718
Copy link
Contributor

@krish2718 krish2718 commented Nov 30, 2025

Fixes issue in STA and SoftAP modes.

test_chip: PR-1094

Jira: https://nordicsemi.atlassian.net/browse/SHEL-3931

Copilot AI review requested due to automatic review settings November 30, 2025 17:17
@krish2718 krish2718 requested review from a team and D-Triveni as code owners November 30, 2025 17:17
@NordicBuilder NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 30, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 30, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses WiFi peer authorization issues in STA and SoftAP modes by updating dependency versions and adjusting network buffer configuration. The fixes are primarily delivered through updates to the zephyr and nrfxlib dependencies.

  • Updates zephyr and nrfxlib to pull in authorization fixes from upstream PRs
  • Adds network packet buffer configuration to the promiscuous WiFi sample

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
west.yml Updates zephyr revision to pull/3557/head and nrfxlib revision to pull/1941/head to incorporate authorization fixes
samples/wifi/promiscuous/prj.conf Adds CONFIG_NET_PKT_BUF_RX_DATA_POOL_SIZE=20000 to configure RX data pool buffer size

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

west.yml Outdated
- name: zephyr
repo-path: sdk-zephyr
revision: 56fbb4f3c7bba12fb34a5cd111b4ea9f7ad52162
revision: pull/3557/head
Copy link

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using pull request references (e.g., pull/3557/head) as revision values is not recommended for production manifests. Pull request branches can be rebased, force-pushed, or deleted after merge, making builds non-reproducible. Consider using specific commit SHAs instead. Once the referenced PRs are merged, this should be updated to point to the actual merged commit SHA.

Suggested change
revision: pull/3557/head
revision: <MERGED_COMMIT_SHA>

Copilot uses AI. Check for mistakes.
west.yml Outdated
repo-path: sdk-nrfxlib
path: nrfxlib
revision: 5b0b19946f2bb47cfa4aa358322146edee38cbd5
revision: pull/1941/head
Copy link

Copilot AI Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using pull request references (e.g., pull/1941/head) as revision values is not recommended for production manifests. Pull request branches can be rebased, force-pushed, or deleted after merge, making builds non-reproducible. Consider using specific commit SHAs instead. Once the referenced PRs are merged, this should be updated to point to the actual merged commit SHA.

Suggested change
revision: pull/1941/head
revision: <MERGED_COMMIT_SHA>

Copilot uses AI. Check for mistakes.
@krish2718 krish2718 added this to the 3.2.0 milestone Nov 30, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 30, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: bd31b7f67b2b98b8ea35c86f50333785362b4ce1

more details

sdk-nrf:

PR head: bd31b7f67b2b98b8ea35c86f50333785362b4ce1
merge base: afd502684994be053d4339b786943b4c435c1a31
target head (main): afd502684994be053d4339b786943b4c435c1a31
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
modules
│  ├── wfa-qt
│  │  ├── src
│  │  │  │ indigo_api_callback_dut.c
samples
│  ├── wifi
│  │  ├── promiscuous
│  │  │  │ prj.conf

Outputs:

Toolchain

Version: 43683a87ea
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:43683a87ea_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 159
  • ✅ Integration tests
    • ✅ test-sdk-wifi
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

You can find the documentation preview for this PR here.

@krga2022 krga2022 requested a review from divyagona December 1, 2025 03:41
@NordicBuilder NordicBuilder removed the DNM label Dec 1, 2025
@rlubos
Copy link
Contributor

rlubos commented Dec 1, 2025

Please rebase, nrfxlib was updated to the latest revision in other PR.

@rlubos
Copy link
Contributor

rlubos commented Dec 1, 2025

Actually, sdk-zephyr was updated to latest as well, so please keep the sample commit only.

Increase RX data pool to fix data buffer allocation failures.

Fixes SHEL-3917.

Signed-off-by: Triveni Danda <[email protected]>
Make PMF optional by default instead of
forcing it disabled when not configured.

Signed-off-by: Triveni Danda <[email protected]>
Without scan_ssid, the STA sends a broadcast probe and
relies on filter_ssid to match results. Since filter_ssid
is not used, scan_ssid must be enabled to explicitly scan
for the configured SSID.

Signed-off-by: Triveni Danda <[email protected]>
Copilot AI review requested due to automatic review settings December 1, 2025 17:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rlubos rlubos merged commit 77fbeeb into nrfconnect:main Dec 1, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants