Skip to content

Conversation

@alexsven
Copy link
Contributor

@alexsven alexsven commented Dec 5, 2025

  • Remove ERR_CHK from zbus_publush for content control These events are not critical as the user can always press again if the system is too busy to schedule in the event queue.
  • OCT-3263

- Remove ERR_CHK from zbus_publush for content control
  These events are not critical as the user can always press again
  if the system is too busy to schedule in the event queue.
- OCT-3263

Signed-off-by: Alexander Svensen <[email protected]>
Copilot AI review requested due to automatic review settings December 5, 2025 09:39
@alexsven alexsven requested a review from a team as a code owner December 5, 2025 09:39
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 5, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes critical error checking (ERR_CHK) from zbus_chan_pub calls in the content control module and replaces it with simple error logging. The rationale is that these media control events (play, start, stop) are not critical—users can retry the action if the event queue is busy.

Key Changes:

  • Replaced ERR_CHK_MSG macros with if-statement error logging for three zbus publication sites
  • Changed error handling from fatal/critical to non-fatal logging for media control events

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 5, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 2a4b081b740345fd91d9b43769bec5158f3ed988

more details

sdk-nrf:

PR head: 2a4b081b740345fd91d9b43769bec5158f3ed988
merge base: e810cd4201fcb9b787caa67e67f92fa70b0317c5
target head (main): ff39d5a55285d5037fbeec5cd43296840b3c7ec9
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
applications
│  ├── nrf5340_audio
│  │  ├── src
│  │  │  ├── bluetooth
│  │  │  │  ├── bt_content_control
│  │  │  │  │  │ bt_content_ctrl.c

Outputs:

Toolchain

Version: 43683a87ea
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:43683a87ea_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 12
  • ✅ Integration tests
    • ✅ test-sdk-audio
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

You can find the documentation preview for this PR here.

@alexsven alexsven removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants