-
Notifications
You must be signed in to change notification settings - Fork 1.4k
applications: nrf5340_audio: Remove ERR_CHK from zbus_publish #26111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
applications: nrf5340_audio: Remove ERR_CHK from zbus_publish #26111
Conversation
alexsven
commented
Dec 5, 2025
- Remove ERR_CHK from zbus_publush for content control These events are not critical as the user can always press again if the system is too busy to schedule in the event queue.
- OCT-3263
- Remove ERR_CHK from zbus_publush for content control These events are not critical as the user can always press again if the system is too busy to schedule in the event queue. - OCT-3263 Signed-off-by: Alexander Svensen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes critical error checking (ERR_CHK) from zbus_chan_pub calls in the content control module and replaces it with simple error logging. The rationale is that these media control events (play, start, stop) are not critical—users can retry the action if the event queue is busy.
Key Changes:
- Replaced ERR_CHK_MSG macros with if-statement error logging for three zbus publication sites
- Changed error handling from fatal/critical to non-fatal logging for media control events
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 2a4b081b740345fd91d9b43769bec5158f3ed988 more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: 43683a87ea Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. |