Ncsdk 31820 fix failing arch tests #2540
Open
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkondraciuk
requested review from
kl-cruz,
kapi-no,
nika-nordic,
doki-nordic,
masz-nordic,
nordic-segl,
nordic-piks and
mstasiaknordic
adamkondraciuk
force-pushed
the
NCSDK-31820-Fix-failing-arch-tests
branch
from
21f23af to
ad388bf
Compare
kl-cruz
approved these changes
Feb 20, 2025
nordic-piks
approved these changes
Feb 21, 2025
mstasiaknordic
approved these changes
Feb 21, 2025
nordic-segl
approved these changes
Feb 21, 2025
kapi-no
reviewed
Feb 21, 2025
adamkondraciuk
force-pushed
the
NCSDK-31820-Fix-failing-arch-tests
branch
from
ad388bf to
944f470
Compare
kapi-no
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
ACK. I think you should also get a review from @doki-nordic who is the codeowner of the IPC service
kapi-no
reviewed
Feb 21, 2025
| @@ -1249,7 +1246,8 @@ static int backend_init(const struct device *instance) | |||
| MAYBE_CONST struct icbmsg_config *conf = (struct icbmsg_config *)instance->config; | |||
| struct backend_data *dev_data = instance->data; | |||
| #ifdef CONFIG_MULTITHREADING | |||
| static K_THREAD_STACK_DEFINE(ep_bound_work_q_stack, EP_BOUND_WORK_Q_STACK_SIZE); | |||
| static K_THREAD_STACK_DEFINE(ep_bound_work_q_stack, | |||
| CONFIG_IPC_SERVICE_BACKEND_ICBMSG_EP_BOUND_WORK_Q_STACK_SIZE); | |||
There was a problem hiding this comment.
This is just a mild suggestion but we use #define aliases for Kconfig names that are very long. E.g.
Consider improving it if you do another push to this PR. Otherwise, you can ignore this comment
#define EP_BOUND_WORK_Q_STACK_SIZE \
(CONFIG_IPC_SERVICE_BACKEND_ICBMSG_EP_BOUND_WORK_Q_STACK_SIZE)
9126fd2 to
f3e236f
Compare
Add `IPC_SERVICE_BACKEND_ICBMSG_EP_BOUND_WORK_Q_STACK_SIZE` config and parametrize its value depending on the optimization level. Upstream PR #: 86103 Signed-off-by: Adam Kondraciuk <[email protected]>
This reverts commit 28bd478. This commit can be reverted as the cause of test failure has been removed in ipc service by increasing workqueue stack size. Upstream PR #: 86103 Signed-off-by: Adam Kondraciuk <[email protected]>
adamkondraciuk
force-pushed
the
NCSDK-31820-Fix-failing-arch-tests
branch
from
f3e236f to
bb41167
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing arm/arch tests for nRF54H20