treewide: align to modified include paths in nrfx #3355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masz-nordic
force-pushed
the
NRFX-8398
branch
from
54915e8 to
3dd240b
Compare
Remove unnecessary paths. Signed-off-by: Marcin Szymczyk <[email protected]>
masz-nordic
force-pushed
the
NRFX-8398
branch
from
3dd240b to
2e4ccf1
Compare
magp-nordic
reviewed
Oct 14, 2025
| zephyr_include_directories(${NRFX_DIR}) | ||
| zephyr_include_directories(${INC_DIR}) | ||
| zephyr_include_directories(${BSP_DIR}) | ||
| zephyr_include_directories(${SOC_DIR}) |
There was a problem hiding this comment.
If this line is removed, then my solution from https://github.com/nrfconnect/sdk-zephyr/pull/3342/files will not work. It either needs to be restored or my PR needs to be reworked to have all BSP cloned to one predetermined place.
masz-nordic
force-pushed
the
NRFX-8398
branch
from
ad0a5ae to
4f99700
Compare
Do not include MDK directly, instead include nrfx.h Signed-off-by: Marcin Szymczyk <[email protected]>
masz-nordic
force-pushed
the
NRFX-8398
branch
from
4f99700 to
74d7673
Compare
- Remove temporary workaround for SDC in nrfx's reserved resources. - Modify NCS reserved resources to use upstream version with additions instead of creating new file - Align filename Signed-off-by: Marcin Szymczyk <[email protected]>
masz-nordic
force-pushed
the
NRFX-8398
branch
from
74d7673 to
4240301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary include paths in hal_nordic.
Replace MDK specific includes with nrfx include.