Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to eslint 9 and node 20 #28

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

Julusian
Copy link
Contributor

@Julusian Julusian commented Jan 21, 2025

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Feature

Current Behavior

New Behavior

Updates eslint config to be for v9.
This required a large rewrite of the config convert it to the new flat-config structure.
To make sure this worked, I refined the config while building new config files inside sofie-core. There are some new failures due to new rules, but not ridiculous amounts of them or any rules which look misconfigured.

Updates required typescript to latest (5.7.3)

Updated typescript-eslint to latest, resuliting in a bunch of new/renamed/refined rules. This causes a bunch of linter failures that will need tackling per project when updating.

Various tools which were dependencies are now peerDependencies.
This is because yarn 4 does not allow them to be invoked easily, requiring workaround to do so. This now avoids that as it is expected that consumers can install the ones they need and invoke them. Most of these required configs setting up anyway, so shouldn't add much extra maintainance.

Prettier is updated to v3, resulting in some formatting changes, that cause a lot of linter errors.

Testing Instructions

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian changed the title wip: update deps feat: update to eslint 9 and node 20 Jan 21, 2025
@Julusian Julusian marked this pull request as ready for review January 21, 2025 15:15
@nytamin nytamin merged commit aba716a into nrkno:master Feb 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants