Skip to content

Commit

Permalink
feat(linter): update allowed eslint config file extensions
Browse files Browse the repository at this point in the history
  • Loading branch information
TorinFrancis committed Feb 20, 2025
1 parent 639d748 commit 6285a20
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export const getGlobalFlatEslintConfiguration = (
allow: [
// This allows a root project to be present without causing lint errors
// since all projects will depend on this base file.
'^.*/eslint(\\.base)?\\.config\\.[cm]?js$',
'^.*/eslint(\\.base)?\\.config\\.[cm]?[jt]s$',
],
depConstraints: [
{ sourceTag: '*', onlyDependOnLibsWithTags: ['*'] },
Expand Down
6 changes: 4 additions & 2 deletions packages/eslint/src/generators/lint-project/lint-project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,10 @@ function createEsLintConfiguration(
'@nx/dependency-checks': [
'error',
{
// With flat configs, we don't want to include imports in the eslint js/cjs/mjs files to be checked
ignoredFiles: ['{projectRoot}/eslint.config.{js,cjs,mjs}'],
// With flat configs, we don't want to include imports in the eslint js/cjs/mjs/ts/cts/mts files to be checked
ignoredFiles: [
'{projectRoot}/eslint.config.{js,cjs,mjs,ts,cts,mts}',
],
},
],
},
Expand Down
7 changes: 7 additions & 0 deletions packages/eslint/src/utils/flat-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,20 @@ export const eslintFlatConfigFilenames = [
'eslint.config.cjs',
'eslint.config.js',
'eslint.config.mjs',
'eslint.config.cts',
'eslint.config.ts',
'eslint.config.mts',
];

export const baseEslintConfigFilenames = [
'eslint.base.js',
'eslint.base.ts',
'eslint.base.config.cjs',
'eslint.base.config.js',
'eslint.base.config.mjs',
'eslint.base.config.cts',
'eslint.base.config.ts',
'eslint.base.config.mts',
];

export function getRootESLintFlatConfigFilename(tree: Tree): string {
Expand Down

0 comments on commit 6285a20

Please sign in to comment.