chore(misc): clean up

nrwl · Feb 19, 2025 · 7942ad5 · 7942ad5
1 parent 8a2077c
commit 7942ad5
Show file tree

Hide file tree

Showing 6 changed files with 82 additions and 343 deletions.
diff --git a/e2e/nx-init/src/nx-init-cra.test.ts → e2e/nx-init/src/nx-init-react.test.ts b/e2e/nx-init/src/nx-init-cra.test.ts → e2e/nx-init/src/nx-init-react.test.ts
@@ -3,6 +3,7 @@ import {
   checkFilesExist,
   getPackageManagerCommand,
   getPublishedVersion,
+  getSelectedPackageManager,
   readFile,
   readJson,
   runCLI,
@@ -21,6 +22,12 @@ import {
 describe('nx init (for React - legacy)', () => {
   let pmc: ReturnType<typeof getPackageManagerCommand>;
 
+  beforeAll(() => {
+    pmc = getPackageManagerCommand({
+      packageManager: getSelectedPackageManager(),
+    });
+  });
+
   it('should convert to an standalone workspace with Vite', () => {
     const appName = 'my-app';
     createReactApp(appName);
@@ -31,7 +38,7 @@ describe('nx init (for React - legacy)', () => {
       } nx@${getPublishedVersion()} init --no-interactive`
     );
 
-    expect(craToNxOutput).toContain('Successfully created the workspace');
+    expect(craToNxOutput).toContain('Done!');
 
     checkFilesDoNotExist(
       'libs/.gitkeep',

diff --git a/...ges/nx/src/command-line/init/implementation/react/add-vite-commands-to-package-scripts.ts b/...ges/nx/src/command-line/init/implementation/react/add-vite-commands-to-package-scripts.ts
@@ -10,10 +10,12 @@ export function addViteCommandsToPackageScripts(
   const packageJson = readJsonFile(packageJsonPath);
   packageJson.scripts = {
     ...packageJson.scripts,
-    start: 'nx exec -- vite',
-    serve: 'nx exec -- vite',
-    build: `nx exec -- vite build`,
-    test: 'nx exec -- vitest',
+    // These should be replaced by the vite init generator later.
+    start: 'vite',
+    test: 'vitest',
+    dev: 'vite',
+    build: 'vite build',
+    eject: undefined,
   };
   writeJsonFile(packageJsonPath, packageJson, { spaces: 2 });
 }